summaryrefslogtreecommitdiff
path: root/src/drivers/generic
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2019-08-25 13:05:46 +0300
committerPatrick Georgi <pgeorgi@google.com>2019-10-04 16:29:31 +0000
commit08c76e1f7d08ec9ef6481c725dc26fba4441e766 (patch)
tree6d131fe8469bc260fb7538279d8d944c8f6294dc /src/drivers/generic
parentf2e1d0ae9a5f0a96c0a9029c9fd93020216bfe66 (diff)
downloadcoreboot-08c76e1f7d08ec9ef6481c725dc26fba4441e766.tar.xz
devicetree: Fix improper use of chip_operations
Auto-discoverable PCI devices do not require field .enable_dev of chip_operations to be set. They are matched with PCI drivers by the use of PCI vendor and device ID fields. The name given for the chip_operations struct must match the pathname the way it is present in the devicetree.cb files. If there was no match, util/sconfig would currently choose to use the empty weak declaration it creates in static.c file. Change-Id: I684a087a1f8ee4e1a5fd83450cd371fcfdbb6847 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/35096 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Diffstat (limited to 'src/drivers/generic')
-rw-r--r--src/drivers/generic/bayhub/bh720.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/src/drivers/generic/bayhub/bh720.c b/src/drivers/generic/bayhub/bh720.c
index 09fa578e86..b365132f06 100644
--- a/src/drivers/generic/bayhub/bh720.c
+++ b/src/drivers/generic/bayhub/bh720.c
@@ -82,12 +82,6 @@ static const struct pci_driver bayhub_bh720 __pci_driver = {
.devices = pci_device_ids,
};
-static void bh720_enable(struct device *dev)
-{
- dev->ops = &bh720_ops;
-}
-
-struct chip_operations bayhub_bh720_ops = {
+struct chip_operations drivers_generic_bayhub_ops = {
CHIP_NAME("BayHub Technology BH720 PCI to eMMC 5.0 HS200 bridge")
- .enable_dev = bh720_enable,
};