diff options
author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2015-01-14 02:14:21 +1100 |
---|---|---|
committer | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2015-01-15 17:12:13 +0100 |
commit | 660ec7cfdf0b48c135ada6cd67af25d66404d3ba (patch) | |
tree | 378e252f25afb3d8385f3b2a31c9f9f0194e331f /src/drivers/generic | |
parent | b0a00c996d8d60cf207156f0a5176310dc4d7403 (diff) | |
download | coreboot-660ec7cfdf0b48c135ada6cd67af25d66404d3ba.tar.xz |
drivers/i2c/w83795: Fix tautology from wrong return type
The correct type-signature of 'do_smbus_write_byte' is:
int do_smbus_write_byte(u32 smbus_io_base, u32 device, u32 address, u8 val)
and so storing the return type in a 'u32' is inappropriate, leading
to a tautological compare of 'ret < 0' and 'err < 0'.
Change-Id: I65486df7156c70af84fa00c336142d9a45998620
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/8209
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/drivers/generic')
0 files changed, 0 insertions, 0 deletions