diff options
| author | Aaron Durbin <adurbin@chromium.org> | 2018-01-24 16:58:18 -0700 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2018-01-25 22:36:30 +0000 |
| commit | b94a27506ebd027214124985301b553c710292af (patch) | |
| tree | 9ee1a732065e0042a23a0be5447203f23b293a89 /src/drivers/i2c | |
| parent | d861d4e7c38a1db59d5cc9765b91f5d6048f6e17 (diff) | |
| download | coreboot-b94a27506ebd027214124985301b553c710292af.tar.xz | |
drivers/i2c/designware: reduce API complication for bus config
Right now dw_i2c_get_soc_cfg() is expecting the SoC to implement
that callback for obtaining the bus config. However, we're currently
forcing another parameter of struct device so one can do the lookup.
This works for Intel-based systems since the struct device was needed
to program the BAR, etc. However, from an API standpoint, it just
complicates matters by needing to obtain the struct device. The SoC
already has knowlege of its own devices so it can get the config
itself by bus number. Therefore, remove that contraint from the API.
BUG=b:70232394
Change-Id: Id8558f5deedda0963a46a532a7bf984e168fb270
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/23420
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/drivers/i2c')
| -rw-r--r-- | src/drivers/i2c/designware/dw_i2c.c | 4 | ||||
| -rw-r--r-- | src/drivers/i2c/designware/dw_i2c.h | 3 |
2 files changed, 3 insertions, 4 deletions
diff --git a/src/drivers/i2c/designware/dw_i2c.c b/src/drivers/i2c/designware/dw_i2c.c index aeddbbcf01..384cca5783 100644 --- a/src/drivers/i2c/designware/dw_i2c.c +++ b/src/drivers/i2c/designware/dw_i2c.c @@ -772,7 +772,7 @@ void dw_i2c_dev_init(struct device *dev) if (bus < 0) return; - config = dw_i2c_get_soc_cfg(bus, dev); + config = dw_i2c_get_soc_cfg(bus); if (!config) return; @@ -806,7 +806,7 @@ void dw_i2c_acpi_fill_ssdt(struct device *dev) if (bus < 0) return; - bcfg = dw_i2c_get_soc_cfg(bus, dev); + bcfg = dw_i2c_get_soc_cfg(bus); if (!bcfg) return; diff --git a/src/drivers/i2c/designware/dw_i2c.h b/src/drivers/i2c/designware/dw_i2c.h index c97ed7785f..be5e7e32a3 100644 --- a/src/drivers/i2c/designware/dw_i2c.h +++ b/src/drivers/i2c/designware/dw_i2c.h @@ -102,8 +102,7 @@ int dw_i2c_soc_bus_to_devfn(unsigned int bus); * * Returns NULL if i2c config is not found */ -const struct dw_i2c_bus_config *dw_i2c_get_soc_cfg(unsigned int bus, - const struct device *dev); +const struct dw_i2c_bus_config *dw_i2c_get_soc_cfg(unsigned int bus); /* Get I2C controller base address */ uintptr_t dw_i2c_base_address(unsigned int bus); |