diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2014-10-16 12:47:25 +0300 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2014-10-19 06:14:05 +0200 |
| commit | 1729cd85744129104e3e41aac1f18e43b62f79ff (patch) | |
| tree | 37a9e44516fc1d1da23e75266aa672099a2872f2 /src/drivers/intel/fsp | |
| parent | d05d0db0d0cb76776addbd75d264e713dda47880 (diff) | |
| download | coreboot-1729cd85744129104e3e41aac1f18e43b62f79ff.tar.xz | |
x86 romstage: Move stack just below RAMTOP
Placement of romstage stack in RAM was vulnerable for getting corrupted
by decompressed ramstage.
Change-Id: Ic032bd3e69f4ab8dab8e5932df39fab70aa3e769
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/7096
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@google.com>
Diffstat (limited to 'src/drivers/intel/fsp')
| -rw-r--r-- | src/drivers/intel/fsp/cache_as_ram.inc | 1 | ||||
| -rw-r--r-- | src/drivers/intel/fsp/fsp_util.c | 3 |
2 files changed, 1 insertions, 3 deletions
diff --git a/src/drivers/intel/fsp/cache_as_ram.inc b/src/drivers/intel/fsp/cache_as_ram.inc index 40787b5cec..0fc33cbf94 100644 --- a/src/drivers/intel/fsp/cache_as_ram.inc +++ b/src/drivers/intel/fsp/cache_as_ram.inc @@ -19,7 +19,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include <cpu/x86/stack.h> #include <cpu/x86/mtrr.h> #include <cpu/x86/cache.h> #include <cpu/x86/post_code.h> diff --git a/src/drivers/intel/fsp/fsp_util.c b/src/drivers/intel/fsp/fsp_util.c index a9b5624676..e15c82e87d 100644 --- a/src/drivers/intel/fsp/fsp_util.c +++ b/src/drivers/intel/fsp/fsp_util.c @@ -19,7 +19,6 @@ #include <types.h> #include <string.h> -#include <cpu/x86/stack.h> #include <console/console.h> #include <bootstate.h> #include <cbmem.h> @@ -81,7 +80,7 @@ void __attribute__ ((noreturn)) fsp_early_init (FSP_INFO_HEADER *fsp_ptr) #endif memset((void*)&FspRtBuffer, 0, sizeof(FSP_INIT_RT_BUFFER)); - FspRtBuffer.Common.StackTop = (u32 *)ROMSTAGE_STACK; + FspRtBuffer.Common.StackTop = (u32 *)CONFIG_RAMTOP; FspInitParams.NvsBufferPtr = NULL; #if IS_ENABLED(CONFIG_FSP_USES_UPD) |