summaryrefslogtreecommitdiff
path: root/src/drivers/intel
diff options
context:
space:
mode:
authorJulius Werner <jwerner@chromium.org>2019-05-01 16:51:20 -0700
committerPatrick Georgi <pgeorgi@google.com>2019-05-06 10:32:15 +0000
commit7c712bbb6c969ae7014707bfddedd821035a2171 (patch)
tree4c357814eabac828a5d7cea3e0bd90b5b15851d1 /src/drivers/intel
parent9d3fa7a22985a2ae080a8e36c89107691d15174f (diff)
downloadcoreboot-7c712bbb6c969ae7014707bfddedd821035a2171.tar.xz
Fix code that would trip -Wtype-limits
This patch fixes up all code that would throw a -Wtype-limits warning. This sometimes involves eliminating unnecessary checks, adding a few odd but harmless casts or just pragma'ing out the warning for a whole file -- I tried to find the path of least resistance. I think the overall benefit of the warning outweighs the occasional weirdness. Change-Id: Iacd37eb1fad388d9db7267ceccb03e6dcf1ad0d2 Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32537 Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/drivers/intel')
-rw-r--r--src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c9
1 files changed, 0 insertions, 9 deletions
diff --git a/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c b/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
index e26701b099..cdc98e06de 100644
--- a/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
+++ b/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
@@ -45,9 +45,6 @@ static efi_return_status_t mp_get_processor_info(const
efi_uintn_t processor_number,
efi_processor_information *processor_info_buffer)
{
- if (cpu_index() < 0)
- return FSP_DEVICE_ERROR;
-
if (processor_info_buffer == NULL)
return FSP_INVALID_PARAMETER;
@@ -71,9 +68,6 @@ static efi_return_status_t mp_startup_all_aps(const
efi_ap_procedure procedure, efi_boolean_t ignored3,
efi_uintn_t timeout_usec, void *argument)
{
- if (cpu_index() < 0)
- return FSP_DEVICE_ERROR;
-
if (procedure == NULL)
return FSP_INVALID_PARAMETER;
@@ -91,9 +85,6 @@ static efi_return_status_t mp_startup_this_ap(const
efi_ap_procedure procedure, efi_uintn_t processor_number,
efi_uintn_t timeout_usec, void *argument)
{
- if (cpu_index() < 0)
- return FSP_DEVICE_ERROR;
-
if (processor_number > get_cpu_count())
return FSP_NOT_FOUND;