diff options
| author | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2015-08-29 17:48:01 -0700 |
|---|---|---|
| committer | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2015-08-31 03:17:02 +0000 |
| commit | 681012ab3d500bcbda3971d122e60587133df1cd (patch) | |
| tree | d13ae3fef0940438f679fd7b005ac774dfab5d5d /src/drivers | |
| parent | 9c98664480de39ecd9d615dc46d34a63aedd4280 (diff) | |
| download | coreboot-681012ab3d500bcbda3971d122e60587133df1cd.tar.xz | |
drivers/intel/fsp_1_1: Remove useless #ifndef/#error pairs
The #error messages only say that "CONFIG_* must be defined", which
conveys no more information that the compiler or assembler failing
when it encounters an undefined CONFIG_* symbol.
Change-Id: I6058474d4cd454cfc20290650425d379f388abd9
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/11461
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/drivers')
| -rw-r--r-- | src/drivers/intel/fsp1_1/cache_as_ram.inc | 18 | ||||
| -rw-r--r-- | src/drivers/intel/fsp1_1/fsp_util.c | 4 |
2 files changed, 0 insertions, 22 deletions
diff --git a/src/drivers/intel/fsp1_1/cache_as_ram.inc b/src/drivers/intel/fsp1_1/cache_as_ram.inc index f56d841380..6af30ce5e5 100644 --- a/src/drivers/intel/fsp1_1/cache_as_ram.inc +++ b/src/drivers/intel/fsp1_1/cache_as_ram.inc @@ -33,24 +33,6 @@ #include <cpu/x86/post_code.h> #include <cbmem.h> -#ifndef CONFIG_FSP_LOC -# error "CONFIG_FSP_LOC must be set." -#endif - -#ifndef CONFIG_POST_IO -# error "CONFIG_POST_IO must be set." -#endif - -#if IS_ENABLED(CONFIG_POST_IO) -# ifndef CONFIG_POST_IO_PORT -# error "CONFIG_POST_IO_PORT must be set." -# endif -#endif - -#ifndef CONFIG_CPU_MICROCODE_CBFS_LOC -# error "CONFIG_CPU_MICROCODE_CBFS_LOC must be set." -#endif - #define LHLT_DELAY 0x50000 /* I/O delay between post codes on failure */ /* diff --git a/src/drivers/intel/fsp1_1/fsp_util.c b/src/drivers/intel/fsp1_1/fsp_util.c index 51ddc67de3..e5624b3c43 100644 --- a/src/drivers/intel/fsp1_1/fsp_util.c +++ b/src/drivers/intel/fsp1_1/fsp_util.c @@ -38,10 +38,6 @@ FSP_INFO_HEADER *find_fsp(void) } fsp_ptr; u32 *image_id; -#ifndef CONFIG_FSP_LOC -#error "CONFIG_FSP_LOC must be set." -#endif - for (;;) { /* Get the FSP binary base address in CBFS */ fsp_ptr.u8 = (u8 *)CONFIG_FSP_LOC; |