diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2018-10-30 15:05:18 -0700 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2018-11-06 17:38:43 +0000 |
| commit | 55a972236ee93d36bd3df4e8e5680ba447242bd7 (patch) | |
| tree | 8b5fc2c3787f06205a2a873e532ad0b39da289d5 /src/ec/google/chromeec/acpi | |
| parent | d840e2b3f019cd37920d6a2ca3c4cfd6f5432699 (diff) | |
| download | coreboot-55a972236ee93d36bd3df4e8e5680ba447242bd7.tar.xz | |
chromeec: Disable battery remaining capacity workaround
If remaining charge is more than x% of the full capacity, the
remaining charge is raised to the full capacity before it's
reported to the rest of the system.
Some batteries don't update full capacity timely or don't update it
at all. On such systems, compensation is required to guarantee
the remaining charge will be equal to the full capacity eventually.
On some systems, Rohm charger generates audio noise when the battery
is fully charged and AC is plugged. A workaround is to do charge-
discharge cycles between 93 and 100%. On such systems, compensation
was also applied to mask this cycle from users.
This used to be done in ACPI, thus, all software components except EC
was able to see the compensated charge. This patch is part of the
effort of moving the logic to EC. With this and the EC changes, EC
can see what the rest of the system sees, thus, can control LEDs
synchronously (to the display percentage).
Another rationale of this move is EC can perform more granular and
precise compensation than ACPI since it has more knowledge about the
battery and the charger.
CQ-DEPEND=CL:1312204
BUG=b:109954565,b:80270446,chromium:899120
BRANCH=none
TEST=Verify charge LED changes to white (full) on Sona synchronously
to the display percentage.
TEST=Verify charge LED changes to blinking white (low) on Sona
within 30 seconds synchronously to the display percentage.
Change-Id: I0b51911b90dc2e7fcf5c730c54d9fda1fea76aa9
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://review.coreboot.org/29441
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Diffstat (limited to 'src/ec/google/chromeec/acpi')
| -rw-r--r-- | src/ec/google/chromeec/acpi/battery.asl | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl index 0a0caec279..1ff50991c0 100644 --- a/src/ec/google/chromeec/acpi/battery.asl +++ b/src/ec/google/chromeec/acpi/battery.asl @@ -294,8 +294,8 @@ Device (BAT0) }) Name (BSTP, Zero) - // Workaround for full battery status, enabled by default - Name (BFWK, One) + // Workaround for full battery status, disabled by default + Name (BFWK, Zero) // Method to enable full battery workaround Method (BFWE) @@ -384,8 +384,8 @@ Device (BAT1) }) Name (BSTP, Zero) - // Workaround for full battery status, enabled by default - Name (BFWK, One) + // Workaround for full battery status, disabled by default + Name (BFWK, Zero) // Method to enable full battery workaround Method (BFWE) |