diff options
author | Karthikeyan Ramasubramanian <kramasub@chromium.org> | 2018-09-17 16:19:34 -0600 |
---|---|---|
committer | Martin Roth <martinroth@google.com> | 2018-09-20 17:15:26 +0000 |
commit | c80ff8437d61f0867eccc520cc68d19fe181af14 (patch) | |
tree | fd94a2103e48b08c5df10421952a945bc7d68a9e /src/ec/google/chromeec/ec.c | |
parent | 2beadeec3512d6087ae5057da681e50883d04acf (diff) | |
download | coreboot-c80ff8437d61f0867eccc520cc68d19fe181af14.tar.xz |
ec/google/chromeec: Update google_chromeec_get_board_version prototype
The helper function to get the board version from EC returns 0 on
failure. But 0 is also a valid board version. Update the helper function
to return -1 on failure and update the use-cases.
BUG=b:114001972,b:114677884,b:114677887
Change-Id: I93e8dbce2ff26e76504b132055985f53cbf07d31
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Tested-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/28576
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Jett Rink <jettrink@google.com>
Diffstat (limited to 'src/ec/google/chromeec/ec.c')
-rw-r--r-- | src/ec/google/chromeec/ec.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 09550d57b3..90fcc3d96c 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -637,7 +637,7 @@ int google_chromeec_cbi_get_dram_part_num(char *buf, size_t bufsize) } #ifndef __SMM__ -u16 google_chromeec_get_board_version(void) +int google_chromeec_get_board_version(uint32_t *version) { struct chromeec_command cmd; struct ec_response_board_version board_v; @@ -649,10 +649,11 @@ u16 google_chromeec_get_board_version(void) cmd.cmd_data_out = &board_v; cmd.cmd_dev_index = 0; - if (google_chromeec_command(&cmd) != 0) - return 0; + if (google_chromeec_command(&cmd)) + return -1; - return board_v.board_version; + *version = board_v.board_version; + return 0; } u32 google_chromeec_get_sku_id(void) |