summaryrefslogtreecommitdiff
path: root/src/ec/google/chromeec
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@chromium.org>2015-09-22 09:40:37 -0700
committerPatrick Georgi <pgeorgi@google.com>2015-09-28 09:34:13 +0000
commit20373c03a84f92d9c19d780a84a9bc380015c3de (patch)
tree56eac1f4ced94cd3e04656d8bd8c68780d78ab95 /src/ec/google/chromeec
parent16ea5191207cb14d5fce3e763f18e046701d215b (diff)
downloadcoreboot-20373c03a84f92d9c19d780a84a9bc380015c3de.tar.xz
chromeec: Fix ACPI compile warnings
Recent version of iasl are flagging more things as warnings. Remove unused Local0 uses and make _CRS method serialized to fix these warnings. BUG=chrome-os-partner:40635 BRANCH=none TEST=build glados with iasl-20150717 Change-Id: I1d4535205426dd9a6346f53ff159221cf5cd899a Signed-off-by: Patrick Georgi <pgeorgi@chromium.org> Original-Commit-Id: 8b43f8f24bb7cb33ad0411c24616da66663c2e3e Original-Change-Id: I71eafd91d30d5f50e6211368f0bbc517c8085892 Original-Signed-off-by: Duncan Laurie <dlaurie@chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/302163 Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: http://review.coreboot.org/11716 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src/ec/google/chromeec')
-rw-r--r--src/ec/google/chromeec/acpi/battery.asl8
-rw-r--r--src/ec/google/chromeec/acpi/ec.asl12
2 files changed, 10 insertions, 10 deletions
diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl
index 6c083aeb4f..e3a4c2e814 100644
--- a/src/ec/google/chromeec/acpi/battery.asl
+++ b/src/ec/google/chromeec/acpi/battery.asl
@@ -110,11 +110,11 @@ Device (BAT0)
Store (Local0, Index (PBIF, 1))
// Design Capacity of Warning
- Divide (Multiply (Local0, DWRN), 100, Local1, Local2)
+ Divide (Multiply (Local0, DWRN), 100, , Local2)
Store (Local2, Index (PBIF, 5))
// Design Capacity of Low
- Divide (Multiply (Local0, DLOW), 100, Local1, Local2)
+ Divide (Multiply (Local0, DLOW), 100, , Local2)
Store (Local2, Index (PBIF, 6))
// Get battery info from mainboard
@@ -138,11 +138,11 @@ Device (BAT0)
Store (Local0, Index (PBIX, 2))
// Design Capacity of Warning
- Divide (Multiply (Local0, DWRN), 100, Local1, Local2)
+ Divide (Multiply (Local0, DWRN), 100, , Local2)
Store (Local2, Index (PBIX, 6))
// Design Capacity of Low
- Divide (Multiply (Local0, DLOW), 100, Local1, Local2)
+ Divide (Multiply (Local0, DLOW), 100, , Local2)
Store (Local2, Index (PBIX, 7))
// Cycle Count
diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl
index 8b4f91d8c8..4afb1bc08d 100644
--- a/src/ec/google/chromeec/acpi/ec.asl
+++ b/src/ec/google/chromeec/acpi/ec.asl
@@ -86,7 +86,7 @@ Device (EC0)
}
}
- Method (_CRS, 0, NotSerialized)
+ Method (_CRS, 0, Serialized)
{
Name (ECMD, ResourceTemplate()
{
@@ -257,7 +257,7 @@ Device (EC0)
Method (_Q12, 0, NotSerialized)
{
Store ("EC: THROTTLE START", Debug)
- If (CondRefOf (\_TZ.THRT, Local0)) {
+ If (CondRefOf (\_TZ.THRT)) {
\_TZ.THRT (1)
}
}
@@ -266,7 +266,7 @@ Device (EC0)
Method (_Q13, 0, NotSerialized)
{
Store ("EC: THROTTLE STOP", Debug)
- If (CondRefOf (\_TZ.THRT, Local0)) {
+ If (CondRefOf (\_TZ.THRT)) {
\_TZ.THRT (0)
}
}
@@ -309,7 +309,7 @@ Device (EC0)
Store (ToInteger (Arg0), ^PATI)
/* Temperature is passed in 1/10 Kelvin */
- Divide (ToInteger (Arg1), 10, Local0, Local1)
+ Divide (ToInteger (Arg1), 10, , Local1)
/* Adjust by EC temperature offset */
Subtract (Local1, ^TOFS, ^PATT)
@@ -336,7 +336,7 @@ Device (EC0)
Store (ToInteger (Arg0), ^PATI)
/* Temperature is passed in 1/10 Kelvin */
- Divide (ToInteger (Arg1), 10, Local0, Local1)
+ Divide (ToInteger (Arg1), 10, , Local1)
/* Adjust by EC temperature offset */
Subtract (Local1, ^TOFS, ^PATT)
@@ -385,7 +385,7 @@ Device (EC0)
/* When sensor ID returns 0xFF then no more events */
While (LNotEqual (Local0, EC_TEMP_SENSOR_NOT_PRESENT))
{
- If (CondRefOf (\_SB.DPTF.TEVT, Local1)) {
+ If (CondRefOf (\_SB.DPTF.TEVT)) {
\_SB.DPTF.TEVT (Local0)
}