summaryrefslogtreecommitdiff
path: root/src/ec/google/chromeec
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2020-04-05 14:05:24 +0200
committerAngel Pons <th3fanbus@gmail.com>2020-04-10 11:50:22 +0000
commit2f8ba69b0ee5deafa9bad20c2a7b2b4785fcb565 (patch)
tree05ed912a3b8e0d11daa2d83030f93d9e90d46d90 /src/ec/google/chromeec
parenta461b694a6c0468cd679628aeebf83437027fb45 (diff)
downloadcoreboot-2f8ba69b0ee5deafa9bad20c2a7b2b4785fcb565.tar.xz
Replace DEVICE_NOOP with noop_(set|read)_resources
`.read_resources` and `.set_resources` are the only two device operations that are considered mandatory. Other function pointers can be left NULL. Having dedicated no-op implementations for the two mandatory fields should stop the leaking of no-op pointers to other fields. Change-Id: I6469a7568dc24317c95e238749d878e798b0a362 Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/40207 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr> Reviewed-by: Edward O'Callaghan <quasisec@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/ec/google/chromeec')
-rw-r--r--src/ec/google/chromeec/ec_lpc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c
index c34082c56b..232df8e06a 100644
--- a/src/ec/google/chromeec/ec_lpc.c
+++ b/src/ec/google/chromeec/ec_lpc.c
@@ -438,7 +438,7 @@ static void lpc_ec_read_resources(struct device *dev)
static struct device_operations ops = {
.init = lpc_ec_init,
.read_resources = lpc_ec_read_resources,
- .set_resources = DEVICE_NOOP,
+ .set_resources = noop_set_resources,
#if CONFIG(HAVE_ACPI_TABLES)
.acpi_name = google_chromeec_acpi_name,
.acpi_fill_ssdt = google_chromeec_fill_ssdt_generator,