summaryrefslogtreecommitdiff
path: root/src/ec/google
diff options
context:
space:
mode:
authorMathew King <mathewk@chromium.org>2020-06-02 12:27:06 -0600
committerPatrick Georgi <pgeorgi@google.com>2020-06-06 09:43:54 +0000
commit071182ade30da4bdba6da03ce79abf8df91ee480 (patch)
treeb62cd23f6754e432f0d4e889c2495b1f4bec193c /src/ec/google
parent379aab47f9bf4a804de168b61d3b2a1f6f789a91 (diff)
downloadcoreboot-071182ade30da4bdba6da03ce79abf8df91ee480.tar.xz
ec/google/wilco: Always use current value of battery status bit
According to the Wilco EC spec the BTSC bit of PWSR is always cleared when PWSR is read so that battery status change events are only triggered one time. Testing of the Wilco EC has verified this behavior. This changes the way in which the battery status change bit is used from checking the bit state against the previous value to always issuing a battery event when the BTSC bit is set. The other bits in PWSR indicate state directly and do not behave like the BTSC bit. BUG=b:157113138 TEST=Deploy on Drallion and verify that battery events are generated BRANCH=drallion, sarien Signed-off-by: Mathew King <mathewk@chromium.org> Change-Id: I8fbf2ee1158ddd790b04a20b1eb27a6cce4f5c81 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42017 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Diffstat (limited to 'src/ec/google')
-rw-r--r--src/ec/google/wilco/acpi/event.asl6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/ec/google/wilco/acpi/event.asl b/src/ec/google/wilco/acpi/event.asl
index a98344dd06..bf4bb19be7 100644
--- a/src/ec/google/wilco/acpi/event.asl
+++ b/src/ec/google/wilco/acpi/event.asl
@@ -25,7 +25,11 @@ Method (ECQP, 0, Serialized)
}
}
- If (EBIT (BTSC, Local1)) {
+ /*
+ * Battery status is cleared when read so always use the value from
+ * PWSR directly regardless of the previous value stored in ECPR.
+ */
+ If (EBIT (BTSC, Local0)) {
Printf ("BAT0 Status Change")
Notify (BAT0, 0x80)
}