diff options
| author | Patrick Rudolph <siro@das-labor.org> | 2017-05-21 08:49:44 +0200 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-09-06 04:14:25 +0000 |
| commit | 1194aa8d08938411b3f13ba540dbba97ac58fa13 (patch) | |
| tree | feee754ec1c333e905f7ee2aceec8b22f3a53778 /src/ec/lenovo/h8/h8.c | |
| parent | 746241f114e851623d2031959a99b06a5102708b (diff) | |
| download | coreboot-1194aa8d08938411b3f13ba540dbba97ac58fa13.tar.xz | |
ec/lenovo/h8: Add BDC detection support
* Add support for detecting BDC.
* Allows to turn off power to BDC if no card is installed.
* Should fix https://ticket.coreboot.org/issues/99 .
Add the following devicetree values:
* has_bdc_detection
Set to one to indicate that the following register are sane.
* bdc_gpio_num
SB GPIO num to read.
* bdc_gpio_lvl
SB GPIO level for card to be present (usually zero).
Don't enable BDC power if no card is detected.
As there are no devicetree values yet, the new code doesn't
have any effect.
Change-Id: I506de2eca4b820e6d82de6b2c48a5440462e1db5
Signed-off-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-on: https://review.coreboot.org/19809
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Alexander Couzens <lynxis@fe80.eu>
Diffstat (limited to 'src/ec/lenovo/h8/h8.c')
| -rw-r--r-- | src/ec/lenovo/h8/h8.c | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index 5ea4a2cbec..6f14953ced 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -28,14 +28,6 @@ #include "h8.h" #include "chip.h" -static void h8_bluetooth_enable(int on) -{ - if (on) - ec_set_bit(0x3a, 4); - else - ec_clr_bit(0x3a, 4); -} - void h8_trackpoint_enable(int on) { ec_write(H8_TRACKPOINT_CTRL, @@ -288,8 +280,7 @@ static void h8_enable(struct device *dev) if (get_option(&val, "volume") == CB_SUCCESS && !acpi_is_wakeup_s3()) ec_write(H8_VOLUME_CONTROL, val); - if (get_option(&val, "bluetooth") != CB_SUCCESS) - val = 1; + val = h8_has_bdc(dev) && h8_bluetooth_nv_enable(); h8_bluetooth_enable(val); if (get_option(&val, "wwan") != CB_SUCCESS) |