summaryrefslogtreecommitdiff
path: root/src/ec/lenovo
diff options
context:
space:
mode:
authorAlexandru Gagniuc <mr.nuke.me@gmail.com>2013-11-23 19:22:53 -0600
committerStefan Reinauer <stefan.reinauer@coreboot.org>2013-12-02 22:11:20 +0100
commit72dccce0c9a7cf59ca51a3174fc11eb8899e1761 (patch)
tree0201395e975f173ebc8badcc952598d559e8a745 /src/ec/lenovo
parentbcfcfa4473357eb6272bc8bcc5e03f4ba517bcd2 (diff)
downloadcoreboot-72dccce0c9a7cf59ca51a3174fc11eb8899e1761.tar.xz
global: Fix usage of get_option() to make use of CB_CMOS_ codes
Do not directly check the return value of get_option, but instead compare the returned value against a CB_CMOS_ error code, or against CB_SUCCESS. Change-Id: I2fa7761d13ebb5e9b4606076991a43f18ae370ad Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> Reviewed-on: http://review.coreboot.org/4266 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/ec/lenovo')
-rw-r--r--src/ec/lenovo/h8/h8.c6
-rw-r--r--src/ec/lenovo/pmh7/pmh7.c2
2 files changed, 4 insertions, 4 deletions
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index 0d1a32dce4..5f7060dcd6 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -172,14 +172,14 @@ static void h8_enable(device_t dev)
h8_trackpoint_enable(conf->trackpoint_enable);
h8_usb_power_enable(1);
- if (!get_option(&val, "volume"))
+ if (get_option(&val, "volume") == CB_SUCCESS)
ec_write(H8_VOLUME_CONTROL, val);
- if (!get_option(&val, "bluetooth"))
+ if (get_option(&val, "bluetooth") == CB_SUCCESS)
h8_bluetooth_enable(val);
- if (!get_option(&val, "first_battery")) {
+ if (get_option(&val, "first_battery") == CB_SUCCESS) {
tmp = ec_read(H8_CONFIG3);
tmp &= ~(1 << 4);
tmp |= (val & 1)<< 4;
diff --git a/src/ec/lenovo/pmh7/pmh7.c b/src/ec/lenovo/pmh7/pmh7.c
index 7bbe471979..b02b52aa8e 100644
--- a/src/ec/lenovo/pmh7/pmh7.c
+++ b/src/ec/lenovo/pmh7/pmh7.c
@@ -113,7 +113,7 @@ static void enable_dev(device_t dev)
pmh7_backlight_enable(conf->backlight_enable);
pmh7_dock_event_enable(conf->dock_event_enable);
- if (!get_option(&val, "touchpad"))
+ if (get_option(&val, "touchpad") == CB_SUCCESS)
pmh7_touchpad_enable(val);
}