diff options
| author | Paul Menzel <paulepanter@users.sourceforge.net> | 2016-12-08 00:03:38 +0100 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-02-20 04:46:49 +0100 |
| commit | 2a4a452abc376ad1dd3491c877422c72a7668391 (patch) | |
| tree | c6bbdeb7d7cf4e6da92ea8e87ace861797f94e54 /src/ec/lenovo | |
| parent | 18792314d7b8dde596a9c378b2d47516cbd871f4 (diff) | |
| download | coreboot-2a4a452abc376ad1dd3491c877422c72a7668391.tar.xz | |
ec/lenovo: Add guards to fix build errors without SMBIOS
Not selecting the Kconfig option `GENERATE_SMBIOS_TABLES` the build
fails with the error below.
```
CC ramstage/ec/lenovo/h8/h8.o
src/ec/lenovo/h8/h8.c:201:2: error: unknown field 'get_smbios_strings' specified in initializer
.get_smbios_strings = h8_smbios_strings,
^
src/ec/lenovo/h8/h8.c:201:2: error: initialization from incompatible pointer type [-Werror]
src/ec/lenovo/h8/h8.c:201:2: error: (near initialization for 'h8_dev_ops.read_resources') [-Werror]
cc1: all warnings being treated as errors
```
So add the appropriate preprocessor guards to fix the build error.
Change-Id: I3baed452d422539a805c628a8c4a6a8c2a809317
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: https://review.coreboot.org/17770
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Diffstat (limited to 'src/ec/lenovo')
| -rw-r--r-- | src/ec/lenovo/h8/h8.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index b08509493e..b259d9ae21 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -182,6 +182,7 @@ u8 h8_build_id_and_function_spec_version(char *buf, u8 buf_len) return i; } +#if IS_ENABLED(CONFIG_GENERATE_SMBIOS_TABLES) static void h8_smbios_strings(struct device *dev, struct smbios_type11 *t) { char tpec[] = "IBM ThinkPad Embedded Controller -[ ]-"; @@ -190,6 +191,7 @@ static void h8_smbios_strings(struct device *dev, struct smbios_type11 *t) t->count = smbios_add_string(t->eos, tpec); } +#endif static void h8_init(device_t dev) { @@ -197,7 +199,9 @@ static void h8_init(device_t dev) } struct device_operations h8_dev_ops = { +#if IS_ENABLED(CONFIG_GENERATE_SMBIOS_TABLES) .get_smbios_strings = h8_smbios_strings, +#endif .init = h8_init, }; |