diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-06-17 20:13:08 +1000 |
|---|---|---|
| committer | Patrick Georgi <patrick@georgi-clan.de> | 2014-06-25 11:34:05 +0200 |
| commit | b57fef9f3e2b3cb8d8c8c5a3552c94a28ff81d15 (patch) | |
| tree | cbc071f1b5b0f1e9db6458ede866ba76072c86fa /src/ec/quanta | |
| parent | 0ddb82671cae52571e92b7b22cf088939d887d50 (diff) | |
| download | coreboot-b57fef9f3e2b3cb8d8c8c5a3552c94a28ff81d15.tar.xz | |
src/ec: Sanitize headers and comment #endif pairings
Comment #endif /* FOO */ pairings.
Alphabetise headers and remove any #if CONFIG_ guards around them.
Background rational:
Remove guarding the inclusion of headers based on CONFIG_ options. This
*potentially* could hide issues such as functions being swapped from
under our feet, since different runtime behaviour could be declared with
the same function same name and type-signature. Hence, depending on the
header we happen to get may change runtime behaviour.
Change-Id: Ic61bdfb64d99f0e2998c6451ae6686915b7bb3d4
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/6059
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
Diffstat (limited to 'src/ec/quanta')
| -rw-r--r-- | src/ec/quanta/ene_kb3940q/ec.c | 5 | ||||
| -rw-r--r-- | src/ec/quanta/it8518/ec.c | 13 |
2 files changed, 7 insertions, 11 deletions
diff --git a/src/ec/quanta/ene_kb3940q/ec.c b/src/ec/quanta/ene_kb3940q/ec.c index 7d0e6ae309..f0a2308e8a 100644 --- a/src/ec/quanta/ene_kb3940q/ec.c +++ b/src/ec/quanta/ene_kb3940q/ec.c @@ -21,14 +21,15 @@ #ifndef __PRE_RAM__ -#include <console/console.h> #include <arch/io.h> +#include <console/console.h> #include <device/device.h> #include <device/pnp.h> -#include <stdlib.h> #include <delay.h> #include <elog.h> +#include <stdlib.h> #include <pc80/keyboard.h> + #include "ec.h" #include "chip.h" diff --git a/src/ec/quanta/it8518/ec.c b/src/ec/quanta/it8518/ec.c index 9e6d3d0847..b9cb68f088 100644 --- a/src/ec/quanta/it8518/ec.c +++ b/src/ec/quanta/it8518/ec.c @@ -19,19 +19,14 @@ * MA 02110-1301 USA */ - - +#include <arch/io.h> #include <console/console.h> -#include <pc80/keyboard.h> - -#ifndef __PRE_RAM__ +#include <delay.h> #include <device/device.h> #include <device/pnp.h> -#endif - +#include <pc80/keyboard.h> #include <stdlib.h> -#include <arch/io.h> -#include <delay.h> + #include "ec.h" #include "chip.h" |