diff options
| author | Nico Huber <nico.h@gmx.de> | 2020-04-05 13:55:12 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2020-04-10 11:25:04 +0000 |
| commit | a461b694a6c0468cd679628aeebf83437027fb45 (patch) | |
| tree | 6ba4647074e37d7580ab85683c8aa40358246e4c /src/ec | |
| parent | 9734325f4568c19d1ffc392084aa431a810a0709 (diff) | |
| download | coreboot-a461b694a6c0468cd679628aeebf83437027fb45.tar.xz | |
Drop unnecessary DEVICE_NOOP entries
Providing an explicit no-op function pointer is only necessary for
`.read_resources` and `.set_resources`. All other device-operation
pointers are optional and can be NULL.
Change-Id: I3d139f7be86180558cabec04b8566873062e33be
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40206
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/ec')
| -rw-r--r-- | src/ec/compal/ene932/ec.c | 1 | ||||
| -rw-r--r-- | src/ec/google/chromeec/ec_lpc.c | 1 | ||||
| -rw-r--r-- | src/ec/google/wilco/chip.c | 1 | ||||
| -rw-r--r-- | src/ec/quanta/ene_kb3940q/ec.c | 1 | ||||
| -rw-r--r-- | src/ec/quanta/it8518/ec.c | 1 | ||||
| -rw-r--r-- | src/ec/roda/it8518/ec.c | 1 |
6 files changed, 0 insertions, 6 deletions
diff --git a/src/ec/compal/ene932/ec.c b/src/ec/compal/ene932/ec.c index 8eebfa8c3a..a022fa7580 100644 --- a/src/ec/compal/ene932/ec.c +++ b/src/ec/compal/ene932/ec.c @@ -123,7 +123,6 @@ static void ene932_init(struct device *dev) static struct device_operations ops = { .init = ene932_init, .read_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, }; static struct pnp_info pnp_dev_info[] = { diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c index dd78922d00..c34082c56b 100644 --- a/src/ec/google/chromeec/ec_lpc.c +++ b/src/ec/google/chromeec/ec_lpc.c @@ -438,7 +438,6 @@ static void lpc_ec_read_resources(struct device *dev) static struct device_operations ops = { .init = lpc_ec_init, .read_resources = lpc_ec_read_resources, - .enable_resources = DEVICE_NOOP, .set_resources = DEVICE_NOOP, #if CONFIG(HAVE_ACPI_TABLES) .acpi_name = google_chromeec_acpi_name, diff --git a/src/ec/google/wilco/chip.c b/src/ec/google/wilco/chip.c index 2ce9bf0ad4..f4bea48be4 100644 --- a/src/ec/google/wilco/chip.c +++ b/src/ec/google/wilco/chip.c @@ -219,7 +219,6 @@ static const char *wilco_ec_acpi_name(const struct device *dev) static struct device_operations ops = { .init = wilco_ec_init, .read_resources = wilco_ec_read_resources, - .enable_resources = DEVICE_NOOP, .set_resources = DEVICE_NOOP, .acpi_fill_ssdt = wilco_ec_fill_ssdt_generator, .acpi_name = wilco_ec_acpi_name, diff --git a/src/ec/quanta/ene_kb3940q/ec.c b/src/ec/quanta/ene_kb3940q/ec.c index 15c04003c3..f6acd218a7 100644 --- a/src/ec/quanta/ene_kb3940q/ec.c +++ b/src/ec/quanta/ene_kb3940q/ec.c @@ -133,7 +133,6 @@ static void ene_kb3940q_init(struct device *dev) static struct device_operations ops = { .init = ene_kb3940q_init, .read_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, }; static struct pnp_info pnp_dev_info[] = { diff --git a/src/ec/quanta/it8518/ec.c b/src/ec/quanta/it8518/ec.c index fd17097d0c..19c07c50a0 100644 --- a/src/ec/quanta/it8518/ec.c +++ b/src/ec/quanta/it8518/ec.c @@ -147,7 +147,6 @@ static void it8518_init(struct device *dev) static struct device_operations ops = { .init = it8518_init, .read_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, }; static struct pnp_info pnp_dev_info[] = { diff --git a/src/ec/roda/it8518/ec.c b/src/ec/roda/it8518/ec.c index 8f36decd68..02f4c9b9db 100644 --- a/src/ec/roda/it8518/ec.c +++ b/src/ec/roda/it8518/ec.c @@ -36,7 +36,6 @@ static void it8518_init(struct device *dev) static struct device_operations ops = { .init = it8518_init, .read_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, }; static struct pnp_info pnp_dev_info[] = { |