diff options
| author | Vladimir Serbinenko <phcoder@gmail.com> | 2013-11-26 02:41:26 +0100 |
|---|---|---|
| committer | Vladimir Serbinenko <phcoder@gmail.com> | 2014-01-10 18:08:16 +0100 |
| commit | a37383db8081b66eafc3860ede23edbfd39ac8ad (patch) | |
| tree | 3f793f4b2342aa440efe3fa649244ec064ced5d8 /src/ec | |
| parent | 4b5012a4a2bf804d395ae3a72c76f50c4a9189db (diff) | |
| download | coreboot-a37383db8081b66eafc3860ede23edbfd39ac8ad.tar.xz | |
Replace all occurences of sprintf with snprintf
THis reduces risks of bufer overflows.
Change-Id: I77f80e76efec16ac0a0af83d76430a8126a7602d
Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
Reviewed-on: http://review.coreboot.org/4279
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/ec')
| -rw-r--r-- | src/ec/lenovo/h8/h8.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index 4f9d2281ab..213ede352b 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -125,14 +125,14 @@ u8 h8_build_id_and_function_spec_version(char *buf, u8 buf_len) for (i = 0; i < 8; i++) { c = ec_read(0xf0 + i); if (c < 0x20 || c > 0x7f) { - i = sprintf(str, "*INVALID"); + i = snprintf(str, sizeof (str), "*INVALID"); break; } str[i] = c; } /* EC firmware function specification version */ - i += sprintf(str + i, "-%u.%u", ec_read(0xef), ec_read(0xeb)); + i += snprintf(str + i, sizeof (str) - i, "-%u.%u", ec_read(0xef), ec_read(0xeb)); i = MIN(buf_len, i); memcpy(buf, str, i); |