summaryrefslogtreecommitdiff
path: root/src/include/boot
diff options
context:
space:
mode:
authorAaron Durbin <adurbin@chromium.org>2017-05-16 21:39:50 -0500
committerAaron Durbin <adurbin@chromium.org>2017-05-18 15:42:23 +0200
commitbdb5c8feaed4cf914b474deeb30686e327ee9228 (patch)
tree0c4a68347fece1616c062abb2c607e0c734c30a2 /src/include/boot
parent43314ffae53b813c6a0d6e34723921316cf46f45 (diff)
downloadcoreboot-bdb5c8feaed4cf914b474deeb30686e327ee9228.tar.xz
coreboot_tables: specify clear interface for lb_framebuffer()
For some reason the "interface" for adding framebuffer information is sitting in src/include/vbe.h while also guarding the call to fill_lb_framebuffer() with vbe_mode_info_valid() along with some macro if CONFIG_* for good measure. Move the fill_lb_framebuffer() declaration to coreboot_tables.h and provide a comment about how it should be used. Also, now that there's no need for the notion of a global vbe_mode_info_valid() remove it from the conditional call path of fill_lb_framebuffer(). Change-Id: Ib3ade6314624091ae70424664527a02b279d0c9b Signed-off-by: Aaron Durbin <adurbin@chromium.org> Signed-off-by: Nico Huber <nico.huber@secunet.com> Reviewed-on: https://review.coreboot.org/19729 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/include/boot')
-rw-r--r--src/include/boot/coreboot_tables.h5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/include/boot/coreboot_tables.h b/src/include/boot/coreboot_tables.h
index 5647629d76..5bebd4a623 100644
--- a/src/include/boot/coreboot_tables.h
+++ b/src/include/boot/coreboot_tables.h
@@ -22,8 +22,9 @@ void lb_add_console(uint16_t consoletype, void *data);
/* Define this in mainboard.c to add board-specific table entries. */
void lb_board(struct lb_header *header);
-/* Define this in soc or fsp driver to add specific table entries. */
-void lb_framebuffer(struct lb_header *header);
+/* Define this function to fill in the frame buffer returning 0 on success and
+ < 0 on error. */
+int fill_lb_framebuffer(struct lb_framebuffer *framebuffer);
/* Allow arch to add records. */
void lb_arch_add_records(struct lb_header *header);