diff options
author | Julius Werner <jwerner@chromium.org> | 2019-12-05 22:29:07 -0800 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2020-01-18 10:51:04 +0000 |
commit | 815611ef56fd1059ae79f0024cb36454a69a05fc (patch) | |
tree | 9c559cb5a04ebf60d9aa6a0e32b36a9d517bbf96 /src/include/cbfs.h | |
parent | 029d67278bd53ef9918045712880f3cc9c61a605 (diff) | |
download | coreboot-815611ef56fd1059ae79f0024cb36454a69a05fc.tar.xz |
cbfs: Remove locator concept
When vboot was first integrated into CBFS it was still part of Google
vendorcode. So to not directly tie custom vendorcode into the core CBFS
library, the concept of cbfs_locator was introduced to decouple core
code from an arbitrary amount of platform-specific implementations that
want to decide where the CBFS can be found.
Nowadays vboot is a core coreboot feature itself, and the locator
concept isn't used by anything else anymore. This patch simplifies the
code by removing it and just calling vboot from the CBFS library
directly. That should make it easier to more closely integrate vboot
into CBFS in the future.
Change-Id: I7b9112adc7b53aa218c58b8cb5c85982dcc1dbc0
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38419
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/include/cbfs.h')
-rw-r--r-- | src/include/cbfs.h | 30 |
1 files changed, 1 insertions, 29 deletions
diff --git a/src/include/cbfs.h b/src/include/cbfs.h index 7a984b8570..2d16aa761a 100644 --- a/src/include/cbfs.h +++ b/src/include/cbfs.h @@ -59,36 +59,8 @@ size_t cbfs_prog_stage_section(struct prog *pstage, uintptr_t *base); /* Load stage into memory filling in prog. Return 0 on success. < 0 on error. */ int cbfs_prog_stage_load(struct prog *prog); -/***************************************************************** - * Support structures and functions. Direct field access should * - * only be done by implementers of cbfs regions -- Not the above * - * API. * - *****************************************************************/ - -/* The cbfs_props struct describes the properties associated with a CBFS. */ -struct cbfs_props { - /* CBFS starts at the following offset within the boot region. */ - size_t offset; - /* CBFS size. */ - size_t size; -}; - -/* Default CBFS locator .locate() callback that locates "COREBOOT" region. This - function is exposed to reduce code duplication in other parts of the code - base. To obtain the correct region device the selection process is required - by way of cbfs_boot_region_device(). */ -int cbfs_default_region_device(struct region_device *rdev); - -/* Select the boot region device from the cbfs locators. +/* Returns the region device of the currently active CBFS. Return < 0 on error, 0 on success. */ int cbfs_boot_region_device(struct region_device *rdev); -/* Object used to identify location of current cbfs to use for cbfs_boot_* - * operations. It's used by cbfs_boot_region_properties(). */ -struct cbfs_locator { - const char *name; - /* Returns 0 on successful fill of cbfs properties. */ - int (*locate)(struct region_device *rdev); -}; - #endif |