diff options
author | Shawn Nematbakhsh <shawnn@chromium.org> | 2013-08-23 14:12:24 -0700 |
---|---|---|
committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2013-09-24 01:23:17 +0200 |
commit | dd6c4ec1ed64f3d9803cca6eb53fa5049cacdd09 (patch) | |
tree | f439cf4d92459ae36a5d8cc9aa9579b289a398f4 /src/include/cbmem.h | |
parent | 5a7e127cd429b101814cae0a1ca3fb5de912777c (diff) | |
download | coreboot-dd6c4ec1ed64f3d9803cca6eb53fa5049cacdd09.tar.xz |
libpayload: Remove unnecessary keyboard mode setting code
keyboard_init attempts to read the existing mode register, set the
'XLATE' bit, and write it back. The implementation is buggy because the
keyboard may be active at the time we read the mode, and we can
misinterpret scancode data as the reply to our command. It leads to
problems where the KB gets disabled in firmware.
In fact, setting the 'XLATE' bit is completely unnecessary, even if we
desire QEMU keyboard support. We already set this bit when we initialize
the keyboard in pc_keyboard_init. Basically, this code does nothing
(or worse), so just remove it.
Change-Id: Iab23f03fa8bced74842c33a7d263de5f449bb983
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: http://review.coreboot.org/3883
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/include/cbmem.h')
0 files changed, 0 insertions, 0 deletions