diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-04-19 19:57:01 +0300 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-05-27 13:54:47 +0200 |
| commit | 70d92b9465b1edf646b25b89f1442f7107b5f1f6 (patch) | |
| tree | 8d0a39990358f3fd92b00f0e790b7667ca90fd1c /src/include/cbmem.h | |
| parent | ef8bb9136e9371753e50cb15b334c9d0f5c70930 (diff) | |
| download | coreboot-70d92b9465b1edf646b25b89f1442f7107b5f1f6.tar.xz | |
CBMEM: Clarify CBMEM_TOP_BACKUP function usage
The deprecated LATE_CBMEM_INIT function is renamed:
set_top_of_ram -> set_late_cbmem_top
Obscure term top_of_ram is replaced:
backup_top_of_ram -> backup_top_of_low_cacheable
get_top_of_ram -> restore_top_of_low_cacheable
New function that always resolves to CBMEM top boundary, with
or without SMM, is named restore_cbmem_top().
Change-Id: I61d20f94840ad61e9fd55976e5aa8c27040b8fb7
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/19377
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>
Diffstat (limited to 'src/include/cbmem.h')
| -rw-r--r-- | src/include/cbmem.h | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/src/include/cbmem.h b/src/include/cbmem.h index 21ca0975f9..68f3615565 100644 --- a/src/include/cbmem.h +++ b/src/include/cbmem.h @@ -151,12 +151,15 @@ void cbmem_add_records_to_cbtable(struct lb_header *header); * value stored in nvram to enable early recovery on S3 path. */ #if IS_ENABLED(CONFIG_ARCH_X86) -/* Note that many of the current providers of get_top_of_ram() conditionally - * return 0 when the sleep type is non S3. i.e. cold and warm boots would - * return 0 from get_top_of_ram(). */ -unsigned long get_top_of_ram(void); -void set_top_of_ram(uint64_t ramtop); -void backup_top_of_ram(uint64_t ramtop); +/* Note that with LATE_CBMEM_INIT, restore_top_of_low_cacheable() + * may conditionally return 0 when the sleep type is non S3, + * i.e. cold and warm boots would return NULL also for cbmem_top. */ +void backup_top_of_low_cacheable(uintptr_t ramtop); +uintptr_t restore_top_of_low_cacheable(void); +uintptr_t restore_cbmem_top(void); + +/* Deprecated, only use with LATE_CBMEM_INIT. */ +void set_late_cbmem_top(uintptr_t ramtop); #endif /* |