diff options
author | Stefan Reinauer <reinauer@chromium.org> | 2015-01-05 13:12:38 -0800 |
---|---|---|
committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2015-01-09 06:12:22 +0100 |
commit | d6865222c84c9da02cb515329af6a5384638d521 (patch) | |
tree | 813e9b2d76cb4d17d68acb505abac4279efbc3ad /src/include/console/console.h | |
parent | c62ee70b6ef651288c4c4710319ee313b28fd520 (diff) | |
download | coreboot-d6865222c84c9da02cb515329af6a5384638d521.tar.xz |
misc: Drop print_ implementation from non-romcc boards
Because we had no stack on romcc boards, we had a separate, not as
powerful clone of printk: print_*.
Back in the day, like more than half a decade ago, we migrated a lot
of boards to printk, but we never cleaned up the existing code to be
consistent. Instead, we worked around the problem with a very messy
console.h (nowadays the mess is hidden in romstage_console.c and
early_print.h)
This patch cleans up the generic code pieces to use printk() on all
non-ROMCC boards.
Our two remaining ROMCC boards are fixed up in this commit:
bifferos/bifferboard and dmp/vortex86ex.
Change-Id: I16676eeabe5c892c8e3c9f3c0cd3bae2e8fd74b6
Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-on: http://review.coreboot.org/8115
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-by: Andrew Wu <arw@dmp.com.tw>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/include/console/console.h')
-rw-r--r-- | src/include/console/console.h | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/src/include/console/console.h b/src/include/console/console.h index 9e98bfc59c..38e05b3fb1 100644 --- a/src/include/console/console.h +++ b/src/include/console/console.h @@ -23,6 +23,7 @@ #include <stdint.h> #include <rules.h> #include <console/post_codes.h> +#include <console/loglevel.h> #ifndef __ROMCC__ void post_code(u8 value); @@ -70,15 +71,6 @@ static inline void do_vtxprintf(const char *fmt, va_list args) {}; #endif #endif -/* A lot of code still uses print_debug() et al. while use of printk() - * would be preferred. - */ -#include <console/early_print.h> - -#else /* __ROMCC__ */ - -#include "arch/x86/lib/romcc_console.c" - -#endif /* __ROMCC__ */ +#endif /* !__ROMCC__ */ #endif /* CONSOLE_CONSOLE_H_ */ |