diff options
| author | Stefan Reinauer <reinauer@chromium.org> | 2015-01-05 13:07:39 -0800 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2015-01-06 20:16:20 +0100 |
| commit | 5491ca23fc2a0dc69ab6efe149050463207462b8 (patch) | |
| tree | 1646414f176752cbc67232888013c8c424de969f /src/include/cpu/x86 | |
| parent | 5ab52ddc3dc289267b603c0a348c461d336aeaf5 (diff) | |
| download | coreboot-5491ca23fc2a0dc69ab6efe149050463207462b8.tar.xz | |
cpu: Drop print_ implementation from non-romcc boards
Because we had no stack on romcc boards, we had a separate, not as
powerful clone of printk: print_*. Back in the day, like more than
half a decade ago, we migrated a lot of boards to printk, but we never
cleaned up the existing code to be consistent. instead, we worked around
the problem with a very messy console.h (nowadays the mess is hidden in
romstage_console.c and early_print.h)
This patch cleans up the cpu code to use printk() on all non-ROMCC
boards.
Change-Id: I233c53300f9a74bce4b828fc4074501a77f7b593
Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-on: http://review.coreboot.org/8114
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/include/cpu/x86')
| -rw-r--r-- | src/include/cpu/x86/bist.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/include/cpu/x86/bist.h b/src/include/cpu/x86/bist.h index d1646bf6c0..08aca2fd02 100644 --- a/src/include/cpu/x86/bist.h +++ b/src/include/cpu/x86/bist.h @@ -4,14 +4,8 @@ static void report_bist_failure(u32 bist) { if (bist != 0) { -#if CONFIG_CACHE_AS_RAM printk(BIOS_EMERG, "BIST failed: %08x", bist); -#else - print_emerg("BIST failed: "); - print_emerg_hex32(bist); -#endif die("\n"); - } } |