diff options
| author | Duncan Laurie <dlaurie@chromium.org> | 2012-10-03 19:01:57 -0700 |
|---|---|---|
| committer | Ronald G. Minnich <rminnich@gmail.com> | 2012-11-14 05:43:26 +0100 |
| commit | 7f3d442abb2a8ff6f6728527ab7665fd79fd60cd (patch) | |
| tree | 5c87a60a4d8e3394c8fe47cac8a9b69943759b66 /src/include/cpu | |
| parent | d396a77b4d144a89a98240541945111280106de6 (diff) | |
| download | coreboot-7f3d442abb2a8ff6f6728527ab7665fd79fd60cd.tar.xz | |
SMM: Avoid use of global variables in SMI handler
Using global variables with the TSEG is a bad idea because
they are not relocated properly right now. Instead make
the variables static and add accessor functions for the
rest of SMM to use.
At the same time drop the tcg/smi1 pointers as they are
not setup or ever used. (the debug output is added back
in a subsequent commit)
Change-Id: If0b2d47df4e482ead71bf713c1ef748da840073b
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: http://review.coreboot.org/1764
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/include/cpu')
| -rw-r--r-- | src/include/cpu/x86/smm.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h index 82a5a1afe4..b52a315017 100644 --- a/src/include/cpu/x86/smm.h +++ b/src/include/cpu/x86/smm.h @@ -384,4 +384,7 @@ u32 smi_get_tseg_base(void); void tseg_relocate(void **ptr); #endif +/* Get PMBASE address */ +u16 smm_get_pmbase(void); + #endif |