summaryrefslogtreecommitdiff
path: root/src/include/device/pnp.h
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2013-06-25 23:17:43 +0300
committerKyösti Mälkki <kyosti.malkki@gmail.com>2013-08-01 15:57:11 +0200
commitef844011491df76eb4976905f2037732e0520295 (patch)
tree45145bccdf8679ee4873c67349b5dc2025009a5c /src/include/device/pnp.h
parent0aede1185be6298bbc9501a0c596e64617bad58b (diff)
downloadcoreboot-ef844011491df76eb4976905f2037732e0520295.tar.xz
Add directive __SIMPLE_DEVICE__
The tests for __PRE_RAM__ or __SMM__ were repeatedly used for detection if dev->ops in the devicetree are not available and simple device model functions need be used. If a source file build for ramstage had __PRE_RAM__ inserted at the beginning, the struct device would no longer match the allocation the object had taken. This problem is fixed by replacing such cases with explicit __SIMPLE_DEVICE__. Change-Id: Ib74c9b2d8753e6e37e1a23fcfaa2f3657790d4c0 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: http://review.coreboot.org/3555 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@google.com>
Diffstat (limited to 'src/include/device/pnp.h')
-rw-r--r--src/include/device/pnp.h6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/include/device/pnp.h b/src/include/device/pnp.h
index 434f0a440e..a229edb966 100644
--- a/src/include/device/pnp.h
+++ b/src/include/device/pnp.h
@@ -2,10 +2,12 @@
#define DEVICE_PNP_H
#include <stdint.h>
+#include <arch/rules.h>
#include <device/device.h>
#include <device/pnp_def.h>
-#if !defined(__PRE_RAM__) && !defined(__SMM__)
+#ifndef __SIMPLE_DEVICE__
+
/* Primitive PNP resource manipulation */
void pnp_write_config(device_t dev, u8 reg, u8 value);
u8 pnp_read_config(device_t dev, u8 reg);
@@ -59,5 +61,5 @@ struct pnp_mode_ops {
void pnp_enter_conf_mode(device_t dev);
void pnp_exit_conf_mode(device_t dev);
-#endif
+#endif /* ! __SIMPLE_DEVICE__ */
#endif /* DEVICE_PNP_H */