summaryrefslogtreecommitdiff
path: root/src/include/device
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-12-05 18:02:32 +0100
committerHung-Te Lin <hungte@chromium.org>2020-12-17 13:53:12 +0000
commit61dd8365bf442a5c07955ef4b1fd665f8c3aadb4 (patch)
treec41738739de5cbf7c79b461abc99a0c0b4bd76f5 /src/include/device
parentc8be0947f1d2665f9ddaca77c9739f55980551ac (diff)
downloadcoreboot-61dd8365bf442a5c07955ef4b1fd665f8c3aadb4.tar.xz
azalia: Make `set_bits` function non-static
There's many copies of this function in the tree. Make the copy in azalia_device.c non-static and rename it to `azalia_set_bits`, then replace all other copies with it. Since azalia_device.c is only built when AZALIA_PLUGIN_SUPPORT is selected, select it where necessary. This has the side-effect of building hda_verb.c from the mainboard directory. If this patch happens to break audio on a mainboard, it's because its hda_verb.c was always wrong but wasn't being compiled. Change-Id: Iff3520131ec7bc8554612969e3a2fe9cdbc9305e Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/48346 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Diffstat (limited to 'src/include/device')
-rw-r--r--src/include/device/azalia_device.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/include/device/azalia_device.h b/src/include/device/azalia_device.h
index d682772e26..7bb8e10fbc 100644
--- a/src/include/device/azalia_device.h
+++ b/src/include/device/azalia_device.h
@@ -18,6 +18,7 @@
#define HDA_ICII_BUSY (1 << 0)
#define HDA_ICII_VALID (1 << 1)
+int azalia_set_bits(void *port, u32 mask, u32 val);
void azalia_audio_init(struct device *dev);
extern struct device_operations default_azalia_audio_ops;