New mechanism to define SRAM/memory map with automatic bounds checking

This patch creates a new mechanism to define the static memory layout
(primarily in SRAM) for a given board, superseding the brittle mass of
Kconfigs that we were using before. The core part is a memlayout.ld file
in the mainboard directory (although boards are expected to just include
the SoC default in most cases), which is the primary linker script for
all stages (though not rmodules for now). It uses preprocessor macros
from <memlayout.h> to form a different valid linker script for all
stages while looking like a declarative, boilerplate-free map of memory
addresses to the programmer. Linker asserts will automatically guarantee
that the defined regions cannot overlap. Stages are defined with a
maximum size that will be enforced by the linker. The file serves to
both define and document the memory layout, so that the documentation
cannot go missing or out of date.

The mechanism is implemented for all boards in the ARM, ARM64 and MIPS
architectures, and should be extended onto all systems using SRAM in the
future. The CAR/XIP environment on x86 has very different requirements
and the layout is generally not as static, so it will stay like it is
and be unaffected by this patch (save for aligning some symbol names for
consistency and sharing the new common ramstage linker script include).

BUG=None
TEST=Booted normally and in recovery mode, checked suspend/resume and
the CBMEM console on Falco, Blaze (both normal and vboot2), Pinky and
Pit. Compiled Ryu, Storm and Urara, manually compared the disassemblies
with ToT and looked for red flags.

Change-Id: Ifd2276417f2036cbe9c056f17e42f051bcd20e81
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: f1e2028e7ebceeb2d71ff366150a37564595e614
Original-Change-Id: I005506add4e8fcdb74db6d5e6cb2d4cb1bd3cda5
Original-Signed-off-by: Julius Werner <jwerner@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/213370
Reviewed-on: http://review.coreboot.org/9283
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Tauner <stefan.tauner@gmx.at>
Reviewed-by: Aaron Durbin <adurbin@google.com>

1 files changed, 105 insertions, 0 deletions

diff --git a/src/include/memlayout.h b/src/include/memlayout.h
new file mode 100644
index 0000000000..a80e03ef85
--- /dev/null
+++ b/src/include/memlayout.h
@@ -0,0 +1,105 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2014 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+/* This file contains macro definitions for memlayout.ld linker scripts. */
+
+#ifndef __MEMLAYOUT_H
+#define __MEMLAYOUT_H
+
+#include <arch/memlayout.h>
+
+#define STR(x) #x
+
+#define SET_COUNTER(name, addr) \
+	_ = ASSERT(. <= addr, STR(name overlaps the previous region!)); \
+	. = addr;
+
+#define SYMBOL(name, addr) \
+	SET_COUNTER(name, addr) \
+	_##name = .;
+
+#define REGION(name, addr, size, expected_align) \
+	SYMBOL(name, addr) \
+	_ = ASSERT(. == ALIGN(expected_align), \
+		STR(name must be aligned to expected_align!)); \
+	SYMBOL(e##name, addr + size)
+
+/* Declare according to SRAM/DRAM ranges in SoC hardware-defined address map. */
+#define SRAM_START(addr) SYMBOL(sram, addr)
+
+#define SRAM_END(addr) SYMBOL(esram, addr)
+
+#define DRAM_START(addr) SYMBOL(dram, addr)
+
+#define PRERAM_CBMEM_CONSOLE(addr, size) \
+	REGION(preram_cbmem_console, addr, size, 4)
+
+/* Use either CBFS_CACHE (unified) or both (PRERAM|POSTRAM)_CBFS_CACHE */
+#define CBFS_CACHE(addr, size) REGION(cbfs_cache, addr, size, 4)
+
+/* TODO: This only works if you never access CBFS in romstage before RAM is up!
+ * If you need to change that assumption, you have some work ahead of you... */
+#if defined(__PRE_RAM__) && !defined(__ROMSTAGE__)
+	#define PRERAM_CBFS_CACHE(addr, size) CBFS_CACHE(addr, size)
+	#define POSTRAM_CBFS_CACHE(addr, size) \
+		REGION(unused_cbfs_cache, addr, size, 4)
+#else
+	#define PRERAM_CBFS_CACHE(addr, size) \
+		REGION(unused_cbfs_cache, addr, size, 4)
+	#define POSTRAM_CBFS_CACHE(addr, size) CBFS_CACHE(addr, size)
+#endif
+
+/* Careful: 'INCLUDE <filename>' must always be at the end of the output line */
+#ifdef __BOOTBLOCK__
+	#define BOOTBLOCK(addr, sz) \
+		SET_COUNTER(bootblock, addr) \
+		_ = ASSERT(_ebootblock - _bootblock <= sz, \
+			STR(Bootblock exceeded its allotted size! (sz))); \
+		INCLUDE "lib/bootblock.bootblock.ld"
+#else
+	#define BOOTBLOCK(addr, sz) \
+		SET_COUNTER(bootblock, addr) \
+		. += sz;
+#endif
+
+#ifdef __ROMSTAGE__
+	#define ROMSTAGE(addr, sz) \
+		SET_COUNTER(romstage, addr) \
+		_ = ASSERT(_eromstage - _romstage <= sz, \
+			STR(Romstage exceeded its allotted size! (sz))); \
+		INCLUDE "lib/romstage.romstage.ld"
+#else
+	#define ROMSTAGE(addr, sz) \
+		SET_COUNTER(romstage, addr) \
+		. += sz;
+#endif
+
+#ifdef __RAMSTAGE__
+	#define RAMSTAGE(addr, sz) \
+		SET_COUNTER(ramstage, addr) \
+		_ = ASSERT(_eramstage - _ramstage <= sz, \
+			STR(Ramstage exceeded its allotted size! (sz))); \
+		INCLUDE "lib/ramstage.ramstage.ld"
+#else
+	#define RAMSTAGE(addr, sz) \
+		SET_COUNTER(ramstage, addr) \
+		. += sz;
+#endif
+
+#endif /* __MEMLAYOUT_H */