diff options
author | Nico Huber <nico.huber@secunet.com> | 2017-08-01 17:09:35 +0200 |
---|---|---|
committer | Martin Roth <martinroth@google.com> | 2017-08-18 15:33:45 +0000 |
commit | 581738642fbeacdf97fc737a41b3128d72cf1a1c (patch) | |
tree | 8f40edb039a66fb6ccdc29b88f7e3b007b048e82 /src/include/types.h | |
parent | 0f2dd1eff9930e30dddd9aabceb5d85ee3b4e980 (diff) | |
download | coreboot-581738642fbeacdf97fc737a41b3128d72cf1a1c.tar.xz |
Reinvent I2C ops
Do not use the global platform_i2c_transfer() function that can only be
implemented by a single driver. Instead, make a `struct device` aware
transfer() function the only interface function for I2C controller dri-
vers to implement.
To not force the slave device drivers to be implemented either above
generic I2C or specialized SMBus operations, we support SMBus control-
lers in the slave device interface too.
We start with four simple slave functions: i2c_readb(), i2c_writeb(),
i2c_readb_at() and i2c_writeb_at(). They are all compatible to respec-
tive SMBus functions. But we keep aliases because it would be weird to
force e.g. an I2C EEPROM driver to call smbus_read_byte().
Change-Id: I98386f91bf4799ba3df84ec8bc0f64edd4142818
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/20846
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/include/types.h')
-rw-r--r-- | src/include/types.h | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/src/include/types.h b/src/include/types.h index df0947370f..7307cd5072 100644 --- a/src/include/types.h +++ b/src/include/types.h @@ -47,7 +47,14 @@ enum cb_err { /* Keyboard test failures */ CB_KBD_CONTROLLER_FAILURE = -200, - CB_KBD_INTERFACE_FAILURE = -201 + CB_KBD_INTERFACE_FAILURE = -201, + + /* I2C controller failures */ + CB_I2C_NO_DEVICE = -300, /**< Device is not responding */ + CB_I2C_BUSY = -301, /**< Device tells it's busy */ + CB_I2C_PROTOCOL_ERROR = -302, /**< Data lost or spurious slave + device response, try again? */ + CB_I2C_TIMEOUT = -303, /**< Transmission timed out */ }; #endif /* __TYPES_H */ |