summaryrefslogtreecommitdiff
path: root/src/include
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@chromium.org>2016-11-30 04:34:22 -0800
committerFurquan Shaikh <furquan@google.com>2016-12-05 03:24:38 +0100
commit0dba0254ea31eca41fdef88783f1dd192ac6fa56 (patch)
tree3c43a2ca9ff4706beb0c0df82cfd96aca75a3927 /src/include
parent52896c6c33250036928406d9dc38aa2ce1906b05 (diff)
downloadcoreboot-0dba0254ea31eca41fdef88783f1dd192ac6fa56.tar.xz
spi: Fix parameter types for spi functions
1. Use size_t instead of unsigned int for bytes_out and bytes_in. 2. Use const attribute for spi_slave structure passed into xfer, claim bus and release bus functions. BUG=chrome-os-partner:59832 BRANCH=None TEST=Compiles successfully Change-Id: Ie70b3520b51c42d750f907892545510c6058f85a Signed-off-by: Furquan Shaikh <furquan@chromium.org> Reviewed-on: https://review.coreboot.org/17682 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/include')
-rw-r--r--src/include/spi-generic.h13
1 files changed, 6 insertions, 7 deletions
diff --git a/src/include/spi-generic.h b/src/include/spi-generic.h
index 347ec3c202..7c53611d79 100644
--- a/src/include/spi-generic.h
+++ b/src/include/spi-generic.h
@@ -17,6 +17,7 @@
#define _SPI_GENERIC_H_
#include <stdint.h>
+#include <stddef.h>
/* Controller-specific definitions: */
@@ -67,7 +68,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs);
* Returns: 0 if the bus was claimed successfully, or a negative value
* if it wasn't.
*/
-int spi_claim_bus(struct spi_slave *slave);
+int spi_claim_bus(const struct spi_slave *slave);
/*-----------------------------------------------------------------------
* Release the SPI bus
@@ -78,7 +79,7 @@ int spi_claim_bus(struct spi_slave *slave);
*
* slave: The SPI slave
*/
-void spi_release_bus(struct spi_slave *slave);
+void spi_release_bus(const struct spi_slave *slave);
/*-----------------------------------------------------------------------
* SPI transfer
@@ -92,10 +93,8 @@ void spi_release_bus(struct spi_slave *slave);
*
* Returns: 0 on success, not 0 on failure
*/
-int spi_xfer(struct spi_slave *slave, const void *dout, unsigned int bytesout,
- void *din, unsigned int bytesin);
-
-
+int spi_xfer(const struct spi_slave *slave, const void *dout, size_t bytesout,
+ void *din, size_t bytesin);
unsigned int spi_crop_chunk(unsigned int cmd_len, unsigned int buf_len);
@@ -108,7 +107,7 @@ unsigned int spi_crop_chunk(unsigned int cmd_len, unsigned int buf_len);
*
* TODO: This function probably shouldn't be inlined.
*/
-static inline int spi_w8r8(struct spi_slave *slave, unsigned char byte)
+static inline int spi_w8r8(const struct spi_slave *slave, unsigned char byte)
{
unsigned char dout[2];
unsigned char din[2];