diff options
| author | Furquan Shaikh <furquan@google.com> | 2021-03-13 22:54:16 -0800 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-03-17 07:56:13 +0000 |
| commit | 7fe5d3d382e25fbdd5026c8e0231dc5a10b57931 (patch) | |
| tree | f97fe6e53afe9ff6f61eee4303cd8b5377c7e87d /src/include | |
| parent | 31f6320afeedfe622b0af51360078be28d26e378 (diff) | |
| download | coreboot-7fe5d3d382e25fbdd5026c8e0231dc5a10b57931.tar.xz | |
sar: Fix semantics of `get_wifi_sar_cbfs_filename()`
Currently, if `get_wifi_sar_cbfs_filename()` returns NULL, then
`get_wifi_sar_limits()` assumes that the default filename is used for
CBFS SAR file. This prevents a board from supporting different models
using the same firmware -- some which require SAR support and some
which don't.
This change updates the logic in `get_wifi_sar_limits()` to return
early if filename is not provided by the mainboard. In order to
maintain the same logic as before, current mainboards are updated to
return WIFI_SAR_CBFS_DEFAULT_FILENAME instead of NULL in default
case.
Change-Id: I68b5bdd213767a3cd81fe41ace66540acd68e26a
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51485
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/sar.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/include/sar.h b/src/include/sar.h index c4a6cd8dbb..78a1b09f2b 100644 --- a/src/include/sar.h +++ b/src/include/sar.h @@ -41,6 +41,8 @@ struct wifi_sar_limits { */ int get_wifi_sar_limits(struct wifi_sar_limits *sar_limits); +#define WIFI_SAR_CBFS_DEFAULT_FILENAME "wifi_sar_defaults.hex" + const char *get_wifi_sar_cbfs_filename(void); #endif /* _SAR_H_ */ |