diff options
| author | Julius Werner <jwerner@chromium.org> | 2021-04-16 16:48:32 -0700 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2021-04-21 02:06:26 +0000 |
| commit | c893197352acc9b53c1beef5082cbc0271f63688 (patch) | |
| tree | b975712387bd54bd0101a736adbb2a6fe5b824bb /src/include | |
| parent | b03e497ef16e9e38ba9220d31131a6bfdef35390 (diff) | |
| download | coreboot-c893197352acc9b53c1beef5082cbc0271f63688.tar.xz | |
commonlib/region: Turn addrspace_32bit into a more official API
We had the addrspace_32bit rdev in prog_loaders.c for a while to help
represent memory ranges as an rdev, and we've found it useful for a
couple of things that have nothing to do with program loading. This
patch moves the concept straight into commonlib/region.c so it is no
longer anchored in such a weird place, and easier to use in unit tests.
Also expand the concept to the whole address space (there's no real need
to restrict it to 32 bits in 64-bit environments) and introduce an
rdev_chain_mem() helper function to make it a bit easier to use. Replace
some direct uses of struct mem_region_device with this new API where it
seems to make sense.
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: Ie4c763b77f77d227768556a9528681d771a08dca
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52533
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/program_loading.h | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/include/program_loading.h b/src/include/program_loading.h index d01eff64d8..65a36b9b2a 100644 --- a/src/include/program_loading.h +++ b/src/include/program_loading.h @@ -91,15 +91,11 @@ static inline void *prog_entry_arg(const struct prog *prog) return prog->arg; } -/* region_device representing the 32-bit flat address space. */ -extern const struct mem_region_device addrspace_32bit; - /* Can be used to get an rdev representation of program area in memory. */ static inline void prog_chain_rdev(const struct prog *prog, struct region_device *rdev_out) { - rdev_chain(rdev_out, &addrspace_32bit.rdev, - (uintptr_t)prog->start, prog->size); + rdev_chain_mem(rdev_out, prog->start, prog->size); } static inline void prog_set_area(struct prog *prog, void *start, size_t size) |