diff options
| author | Felix Singer <felix.singer@9elements.com> | 2019-11-10 11:04:08 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-11-22 10:47:43 +0000 |
| commit | 7f8b0cd89c10621f456e3eebcd290d3946122d6d (patch) | |
| tree | 018baa84262893975bd353807594d0d7f4052a4f /src/include | |
| parent | 94146009a190383a581618fd969bf2276fb73585 (diff) | |
| download | coreboot-7f8b0cd89c10621f456e3eebcd290d3946122d6d.tar.xz | |
sb/i82801ix: Use macros instead of hard-coded IDs
This patch replaces hard-coded PCI IDs with macros
from pci_ids.h and cleans up some code.
Change-Id: Ie6ea72ac49eb015ef5cbaa98ed2b3400072000b5
Signed-off-by: Felix Singer <felix.singer@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36705
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/device/pci_ids.h | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 18d6f601c1..c05640fe9c 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -2546,13 +2546,15 @@ #define PCI_DEVICE_ID_INTEL_82801HEM_LPC 0x2811 /* Intel 82801IB (ICH9) */ -#define PCI_DEVICE_ID_INTEL_82801IB_LPC 0x2918 +#define PCI_DEVICE_ID_INTEL_82801IB_LPC 0x2918 /* ICH9 */ #define PCI_DEVICE_ID_INTEL_82801IB_SATA_P0123 0x2920 /* Ports 0 - 3 */ #define PCI_DEVICE_ID_INTEL_82801IB_SATA_P01 0x2921 /* Ports 0 - 1 */ #define PCI_DEVICE_ID_INTEL_82801IB_SATA_AHCI1 0x2922 /* Ports 0 - 5 */ #define PCI_DEVICE_ID_INTEL_82801IB_SATA_AHCI2 0x2923 /* Ports 0, 1, 4, 5 */ #define PCI_DEVICE_ID_INTEL_82801IB_SATA_RAID 0x2822 /* RAID */ #define PCI_DEVICE_ID_INTEL_82801IB_SATA_P45 0x2926 /* Ports 4 - 5 */ +#define PCI_DEVICE_ID_INTEL_82801IBM_IEM_SATA_IDE_P01 0x2928 /* Ports 0 - 1 */ +#define PCI_DEVICE_ID_INTEL_82801IBM_IEM_SATA_AHCI_P0145 0x2929 /* Ports 0, 1, 4, 5 */ #define PCI_DEVICE_ID_INTEL_82801IB_SMB 0x2930 #define PCI_DEVICE_ID_INTEL_82801IB_THERMAL 0x2932 #define PCI_DEVICE_ID_INTEL_82801IB_PCI 0x244e /* DMI to PCI bridge */ @@ -2573,10 +2575,12 @@ #define PCI_DEVICE_ID_INTEL_82801IB_PCIE6 0x294a #define PCI_DEVICE_ID_INTEL_82801IB_LAN 0x29c4 -/* Intel 82801IR/IH/IO (ICH9R/ICH9DH/ICH9DO), only difference to ICH9: LPC */ -#define PCI_DEVICE_ID_INTEL_82801IR_LPC 0x2916 -#define PCI_DEVICE_ID_INTEL_82801IO_LPC 0x2914 -#define PCI_DEVICE_ID_INTEL_82801IH_LPC 0x2912 +/* Only difference to ICH9: LPC */ +#define PCI_DEVICE_ID_INTEL_82801IH_LPC 0x2912 /* ICH9DH */ +#define PCI_DEVICE_ID_INTEL_82801IO_LPC 0x2914 /* ICH9DO */ +#define PCI_DEVICE_ID_INTEL_82801IR_LPC 0x2916 /* ICH9R */ +#define PCI_DEVICE_ID_INTEL_82801IEM_LPC 0x2917 /* ICH9M-E */ +#define PCI_DEVICE_ID_INTEL_82801IBM_LPC 0x2919 /* ICH9M */ #define PCI_DEVICE_ID_INTEL_CAVECREEK_LPC 0x2310 #define PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MIN 0x1c41 |