diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2014-10-16 12:47:25 +0300 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2014-10-19 06:14:05 +0200 |
| commit | 1729cd85744129104e3e41aac1f18e43b62f79ff (patch) | |
| tree | 37a9e44516fc1d1da23e75266aa672099a2872f2 /src/include | |
| parent | d05d0db0d0cb76776addbd75d264e713dda47880 (diff) | |
| download | coreboot-1729cd85744129104e3e41aac1f18e43b62f79ff.tar.xz | |
x86 romstage: Move stack just below RAMTOP
Placement of romstage stack in RAM was vulnerable for getting corrupted
by decompressed ramstage.
Change-Id: Ic032bd3e69f4ab8dab8e5932df39fab70aa3e769
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/7096
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@google.com>
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/cpu/x86/stack.h | 32 |
1 files changed, 0 insertions, 32 deletions
diff --git a/src/include/cpu/x86/stack.h b/src/include/cpu/x86/stack.h deleted file mode 100644 index 158b670251..0000000000 --- a/src/include/cpu/x86/stack.h +++ /dev/null @@ -1,32 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2010 coresystems GmbH - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA - */ - -#ifndef __CPU_X86_STACK_H -#define __CPU_X86_STACK_H - -/* For now: use CONFIG_RAMBASE + 1MB - 64K (counting downwards) as stack. This - * makes sure that we stay completely within the 1M-64K of memory that we - * preserve for suspend/resume. This is basically HIGH_MEMORY_SAFE (see - * cbmem.h) - */ - -#define ROMSTAGE_STACK_OFFSET ( (1024 - 64) * 1024 ) -#define ROMSTAGE_STACK (CONFIG_RAMBASE + ROMSTAGE_STACK_OFFSET) - -#endif |