diff options
| author | Aaron Durbin <adurbin@chromium.org> | 2017-09-07 21:17:33 -0600 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2017-09-11 01:17:45 +0000 |
| commit | 5a1f9a87cb2f6a3e0699f3d13db41c7da2963b88 (patch) | |
| tree | 516fa2ca773920f67411c1b0560c449f8a529fb7 /src/include | |
| parent | 0b80bd1cf4510b3a4f028b5bb5570a2806c22320 (diff) | |
| download | coreboot-5a1f9a87cb2f6a3e0699f3d13db41c7da2963b88.tar.xz | |
cpu/x86/mp_init: remove adjust_cpu_apic_entry()
The original purpose of adjust_cpu_apic_entry() was to set
up an APIC map. That map was effectively only used for mapping
*default* APIC id to CPU number in the SMM handler. The normal
AP startup path didn't need this mapping because it was whoever
won the race got the next cpu number. Instead of statically
calculating (and wrong) just initialize the default APIC id
map when the APs come online. Once the APs are online the SMM
handler is loaded and the mapping is utilized.
Change-Id: Idff3b8cfc17aef0729d3193b4499116a013b7930
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/21452
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/cpu/x86/mp.h | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/src/include/cpu/x86/mp.h b/src/include/cpu/x86/mp.h index 0671b62551..f6afc84f35 100644 --- a/src/include/cpu/x86/mp.h +++ b/src/include/cpu/x86/mp.h @@ -58,14 +58,6 @@ struct mp_ops { */ void (*get_microcode_info)(const void **microcode, int *parallel); /* - * Optionally provide a function which adjusts the APIC id - * map to CPU number. By default the CPU number and APIC id - * are 1:1. To change the APIC id for a given CPU return the - * new APIC id. It's called for each CPU as indicated by - * get_cpu_count(). - */ - int (*adjust_cpu_apic_entry)(int cpu, int cur_apic_id); - /* * Optionally adjust SMM handler parameters to override the default * values. The is_perm variable indicates if the parameters to adjust * are for the relocation handler or the permanent handler. This |