summaryrefslogtreecommitdiff
path: root/src/lib/Makefile.inc
diff options
context:
space:
mode:
authorJulius Werner <jwerner@chromium.org>2019-05-20 14:53:47 -0700
committerJulius Werner <jwerner@chromium.org>2019-05-31 18:22:11 +0000
commita66c9b8bf4e4db0a108f90c21084ecc25aa87e72 (patch)
tree6859c4839623f61929800b79dfec38974b9a5c30 /src/lib/Makefile.inc
parent7fa3d5673c5d9837d55b6de69419a6871eee8438 (diff)
downloadcoreboot-a66c9b8bf4e4db0a108f90c21084ecc25aa87e72.tar.xz
string.h: Move common string functions into .c file
There's no clear reason why most of coreboot's basic string functions are static inline. These functions don't particularly benefit from inlining (at least not notably more than other functions). This patch moves them to string.c to be more consistent with our usual coding practices. Leaving the ctype functions as static inline because they actually seem small and collapsible enough that inlining seems reasonable. Also clarified the situation of strdup() and strconcat() a bit more, optimized strrchr() to be single-pass, fixed a bug with using strchr() to find '\0' and got rid of unnecessary register keywords. Change-Id: I88166ba9876e94dfa3cfc06969c78a9e1bc6fc36 Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32901 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Alex Thiessen <alex.thiessen.de+coreboot@gmail.com>
Diffstat (limited to 'src/lib/Makefile.inc')
-rw-r--r--src/lib/Makefile.inc9
1 files changed, 8 insertions, 1 deletions
diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc
index 1350152a40..913675bac8 100644
--- a/src/lib/Makefile.inc
+++ b/src/lib/Makefile.inc
@@ -118,7 +118,6 @@ ramstage-y += bootmem.c
ramstage-y += fmap.c
ramstage-y += memchr.c
ramstage-y += memcmp.c
-ramstage-y += string.c
ramstage-y += malloc.c
smm-$(CONFIG_SMM_TSEG) += malloc.c
ramstage-y += dimm_info_util.c
@@ -244,6 +243,14 @@ postcar-y += reset.c
ramstage-y += reset.c
smm-y += reset.c
+decompressor-y += string.c
+bootblock-y += string.c
+verstage-y += string.c
+romstage-y += string.c
+postcar-y += string.c
+ramstage-y += string.c
+smm-y += string.c
+
postcar-y += bootmode.c
postcar-y += boot_device.c
postcar-y += cbfs.c