diff options
| author | Stefan Reinauer <reinauer@chromium.org> | 2015-01-05 13:12:38 -0800 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2015-01-09 06:12:22 +0100 |
| commit | d6865222c84c9da02cb515329af6a5384638d521 (patch) | |
| tree | 813e9b2d76cb4d17d68acb505abac4279efbc3ad /src/lib/generic_sdram.c | |
| parent | c62ee70b6ef651288c4c4710319ee313b28fd520 (diff) | |
| download | coreboot-d6865222c84c9da02cb515329af6a5384638d521.tar.xz | |
misc: Drop print_ implementation from non-romcc boards
Because we had no stack on romcc boards, we had a separate, not as
powerful clone of printk: print_*.
Back in the day, like more than half a decade ago, we migrated a lot
of boards to printk, but we never cleaned up the existing code to be
consistent. Instead, we worked around the problem with a very messy
console.h (nowadays the mess is hidden in romstage_console.c and
early_print.h)
This patch cleans up the generic code pieces to use printk() on all
non-ROMCC boards.
Our two remaining ROMCC boards are fixed up in this commit:
bifferos/bifferboard and dmp/vortex86ex.
Change-Id: I16676eeabe5c892c8e3c9f3c0cd3bae2e8fd74b6
Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-on: http://review.coreboot.org/8115
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-by: Andrew Wu <arw@dmp.com.tw>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/lib/generic_sdram.c')
| -rw-r--r-- | src/lib/generic_sdram.c | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/src/lib/generic_sdram.c b/src/lib/generic_sdram.c index efb61dbf7a..a79d822a52 100644 --- a/src/lib/generic_sdram.c +++ b/src/lib/generic_sdram.c @@ -1,14 +1,5 @@ #include <lib.h> /* Prototypes */ -static inline void print_debug_sdram_8(const char *strval, uint32_t val) -{ -#if CONFIG_CACHE_AS_RAM - printk(BIOS_DEBUG, "%s%02x\n", strval, val); -#else - print_debug(strval); print_debug_hex8(val); print_debug("\n"); -#endif -} - /* Setup SDRAM */ #if CONFIG_RAMINIT_SYSINFO void sdram_initialize(int controllers, const struct mem_controller *ctrl, void *sysinfo) @@ -19,7 +10,7 @@ void sdram_initialize(int controllers, const struct mem_controller *ctrl) int i; /* Set the registers we can set once to reasonable values */ for(i = 0; i < controllers; i++) { - print_debug_sdram_8("Ram1.", i); + printk(BIOS_DEBUG, "Ram1.%02x\n", i); #if CONFIG_RAMINIT_SYSINFO sdram_set_registers(ctrl + i, sysinfo); @@ -30,7 +21,7 @@ void sdram_initialize(int controllers, const struct mem_controller *ctrl) /* Now setup those things we can auto detect */ for(i = 0; i < controllers; i++) { - print_debug_sdram_8("Ram2.", i); + printk(BIOS_DEBUG, "Ram2.%02x\n", i); #if CONFIG_RAMINIT_SYSINFO sdram_set_spd_registers(ctrl + i, sysinfo); @@ -44,7 +35,7 @@ void sdram_initialize(int controllers, const struct mem_controller *ctrl) * Some chipsets do the work for us while on others * we need to it by hand. */ - print_debug("Ram3\n"); + printk(BIOS_DEBUG, "Ram3\n"); #if CONFIG_RAMINIT_SYSINFO sdram_enable(controllers, ctrl, sysinfo); @@ -52,5 +43,5 @@ void sdram_initialize(int controllers, const struct mem_controller *ctrl) sdram_enable(controllers, ctrl); #endif - print_debug("Ram4\n"); + printk(BIOS_DEBUG, "Ram4\n"); } |