diff options
| author | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-09 17:35:28 -0800 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-03-13 17:16:08 +0100 |
| commit | 35af5c47b030c0a1837cb34bc9ae4d50734fefb0 (patch) | |
| tree | 0e0f1d541d170095fe22739d38a7f02d77c4329e /src/lib/libgcov.c | |
| parent | fece39baa5ce730d8467454e5ce407c0bc45cb78 (diff) | |
| download | coreboot-35af5c47b030c0a1837cb34bc9ae4d50734fefb0.tar.xz | |
src/lib: Fix spacing
Fix the following errors and warnings detected by checkpatch.pl:
ERROR: spaces required around that '?' (ctx:WxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '+=' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required before the open brace '{'
ERROR: space required after that close brace '}'
ERROR: need consistent spacing around '+' (ctx:WxV)
ERROR: need consistent spacing around '*' (ctx:WxV)
ERROR: need consistent spacing around '&' (ctx:VxW)
ERROR: spaces required around that '?' (ctx:VxW)
ERROR: spaces required around that ':' (ctx:VxW)
ERROR: trailing whitespace
ERROR: space prohibited before that '++' (ctx:WxO)
ERROR: space prohibited before that ',' (ctx:WxW)
ERROR: space prohibited after that '!' (ctx:BxW)
ERROR: spaces prohibited around that '->' (ctx:VxW)
ERROR: space prohibited after that '-' (ctx:WxW)
WARNING: space prohibited before semicolon
WARNING: unnecessary whitespace before a quoted newline
WARNING: missing space after return type
Note that lib/libgcov.c and lib/lzmadecode.c are providing false
positives for ERROR: need consistent spacing around '*' (ctx:WxV)
An example is:
void __gcov_merge_add(gcov_type *counters __attribute__ ((unused)),
unsigned int n_counters __attribute__ ((unused))) {}
TEST=Build and run on Galileo Gen2
Change-Id: I0016327a5754018eaeb25bedf42338291632c7c1
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18733
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src/lib/libgcov.c')
| -rw-r--r-- | src/lib/libgcov.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/lib/libgcov.c b/src/lib/libgcov.c index d1d2c6e769..3e94664cf3 100644 --- a/src/lib/libgcov.c +++ b/src/lib/libgcov.c @@ -248,7 +248,7 @@ buffer_fn_data(const char *filename, const struct gcov_info *gi_ptr, return &fn_buffer->next; fail: - fprintf(stderr, "profiling:%s:Function %u %s %u \n", filename, fn_ix, + fprintf(stderr, "profiling:%s:Function %u %s %u\n", filename, fn_ix, len ? "cannot allocate" : "counter mismatch", len ? len : ix); return (struct gcov_fn_buffer **)free_fn_data(gi_ptr, fn_buffer, ix); @@ -289,7 +289,7 @@ gcov_version(struct gcov_info *ptr, gcov_unsigned_t version, fprintf(stderr, "profiling:%s:Version mismatch - expected %.4s got %.4s\n", - filename? filename : ptr->filename, e, v); + filename ? filename : ptr->filename, e, v); return 0; } return 1; @@ -603,7 +603,7 @@ gcov_exit(void) read_error:; fprintf(stderr, "profiling:%s:%s merging\n", gi_filename, - error < 0 ? "Overflow": "Error"); + error < 0 ? "Overflow" : "Error"); goto read_fatal; @@ -986,7 +986,7 @@ void __gcov_average_profiler(gcov_type *counters, gcov_type value) { counters[0] += value; - counters[1] ++; + counters[1]++; } #endif |