diff options
| author | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-10 17:56:44 -0800 |
|---|---|---|
| committer | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-15 05:05:04 +0100 |
| commit | 36984d85e758bd7b280a835c5c6e5c68b10e82b6 (patch) | |
| tree | 62b7bdc244d5d3c25120fe37fc107de87468a92b /src/lib/reg_script.c | |
| parent | 491c5b60d01d5fa7d27c281335343e67519e799c (diff) | |
| download | coreboot-36984d85e758bd7b280a835c5c6e5c68b10e82b6.tar.xz | |
src/lib: Clean up general issues found by checkpatch.pl
Fix the following errors and warnings detected by checkpatch.pl:
ERROR: Bad function definition - void init_timer() should probably be void init_timer(void)
ERROR: Prefixing 0x with decimal output is defective
WARNING: Comparisons should place the constant on the right side of the test
WARNING: char * array declaration might be better as static const
TEST=Build and run on Galileo Gen2
Change-Id: I9f618eea95e1f92fa34f4f89da27c0b16ae7f4ee
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18763
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/lib/reg_script.c')
| -rw-r--r-- | src/lib/reg_script.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/reg_script.c b/src/lib/reg_script.c index e3b453d2d0..8d813b6f8d 100644 --- a/src/lib/reg_script.c +++ b/src/lib/reg_script.c @@ -476,7 +476,7 @@ static uint64_t reg_script_read(struct reg_script_context *ctx) /* Read from the platform specific bus */ bus = find_bus(step); - if (NULL != bus) { + if (bus != NULL) { value = bus->reg_script_read(ctx); break; } @@ -530,7 +530,7 @@ static void reg_script_write(struct reg_script_context *ctx) /* Write to the platform specific bus */ bus = find_bus(step); - if (NULL != bus) { + if (bus != NULL) { bus->reg_script_write(ctx); break; } |