diff options
author | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-09 17:35:28 -0800 |
---|---|---|
committer | Martin Roth <martinroth@google.com> | 2017-03-13 17:16:08 +0100 |
commit | 35af5c47b030c0a1837cb34bc9ae4d50734fefb0 (patch) | |
tree | 0e0f1d541d170095fe22739d38a7f02d77c4329e /src/lib/stack.c | |
parent | fece39baa5ce730d8467454e5ce407c0bc45cb78 (diff) | |
download | coreboot-35af5c47b030c0a1837cb34bc9ae4d50734fefb0.tar.xz |
src/lib: Fix spacing
Fix the following errors and warnings detected by checkpatch.pl:
ERROR: spaces required around that '?' (ctx:WxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '+=' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required before the open brace '{'
ERROR: space required after that close brace '}'
ERROR: need consistent spacing around '+' (ctx:WxV)
ERROR: need consistent spacing around '*' (ctx:WxV)
ERROR: need consistent spacing around '&' (ctx:VxW)
ERROR: spaces required around that '?' (ctx:VxW)
ERROR: spaces required around that ':' (ctx:VxW)
ERROR: trailing whitespace
ERROR: space prohibited before that '++' (ctx:WxO)
ERROR: space prohibited before that ',' (ctx:WxW)
ERROR: space prohibited after that '!' (ctx:BxW)
ERROR: spaces prohibited around that '->' (ctx:VxW)
ERROR: space prohibited after that '-' (ctx:WxW)
WARNING: space prohibited before semicolon
WARNING: unnecessary whitespace before a quoted newline
WARNING: missing space after return type
Note that lib/libgcov.c and lib/lzmadecode.c are providing false
positives for ERROR: need consistent spacing around '*' (ctx:WxV)
An example is:
void __gcov_merge_add(gcov_type *counters __attribute__ ((unused)),
unsigned int n_counters __attribute__ ((unused))) {}
TEST=Build and run on Galileo Gen2
Change-Id: I0016327a5754018eaeb25bedf42338291632c7c1
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18733
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src/lib/stack.c')
-rw-r--r-- | src/lib/stack.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/stack.c b/src/lib/stack.c index 590fe27ed7..00c145aa3f 100644 --- a/src/lib/stack.c +++ b/src/lib/stack.c @@ -33,7 +33,7 @@ int checkstack(void *top_of_stack, int core) int i; u32 *stack = (u32 *) (top_of_stack - stack_size); - if (stack[0] != 0xDEADBEEF){ + if (stack[0] != 0xDEADBEEF) { printk(BIOS_ERR, "Stack overrun on CPU%d (address %p overwritten). " "Increase stack from current %zu bytes\n", core, stack, stack_size); @@ -41,7 +41,7 @@ int checkstack(void *top_of_stack, int core) return -1; } - for (i = 1; i < stack_size/sizeof(stack[0]); i++){ + for (i = 1; i < stack_size/sizeof(stack[0]); i++) { if (stack[i] == 0xDEADBEEF) continue; printk(BIOS_SPEW, "CPU%d: stack: %p - %p, ", |