summaryrefslogtreecommitdiff
path: root/src/lib
diff options
context:
space:
mode:
authorNico Huber <nico.huber@secunet.com>2017-06-28 16:42:51 +0200
committerNico Huber <nico.h@gmx.de>2017-06-29 15:41:02 +0000
commit5f9c6734fc9bbe69c007c46c8ec6f314bd5522a8 (patch)
tree8f8ae84291f503c88a92103e5c528b7b0d284b46 /src/lib
parent956cfa307b59ff035f47a6bf4b21456963991839 (diff)
downloadcoreboot-5f9c6734fc9bbe69c007c46c8ec6f314bd5522a8.tar.xz
lib/spd_bin: Use proper I2C addresses
Use the plain address instead of the weird shifted encoding (e.g. if we'd use `0xa0` as address, it's actually `0x50` encoded into a write command). Change-Id: I6febb2e04e1c6de4294dfa37bde16b147a80b7a8 Signed-off-by: Nico Huber <nico.huber@secunet.com> Reviewed-on: https://review.coreboot.org/20405 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/lib')
-rw-r--r--src/lib/spd_bin.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/lib/spd_bin.c b/src/lib/spd_bin.c
index a9f6a36045..b5ab9b7db1 100644
--- a/src/lib/spd_bin.c
+++ b/src/lib/spd_bin.c
@@ -128,8 +128,6 @@ int get_spd_cbfs_rdev(struct region_device *spd_rdev, u8 spd_index)
static void get_spd(u8 *spd, u8 addr)
{
u16 i;
- /* Assuming addr is 8 bit address, make it 7 bit */
- addr = addr >> 1;
if (smbus_read_byte(0, addr, 0) == 0xff) {
printk(BIOS_INFO, "No memory dimm at address %02X\n",
addr << 1);