diff options
| author | Aaron Durbin <adurbin@chromium.org> | 2014-02-08 15:41:52 -0600 |
|---|---|---|
| committer | Aaron Durbin <adurbin@google.com> | 2014-02-09 22:08:53 +0100 |
| commit | ca4f4b8c9eef77fbcad0af3b21885a337a1f2c83 (patch) | |
| tree | d6d185b7a25c9a1f8c0e6105f34178cb0658ba71 /src/lib | |
| parent | 892728c65fcd82cab43e334396b86fc257ecf256 (diff) | |
| download | coreboot-ca4f4b8c9eef77fbcad0af3b21885a337a1f2c83.tar.xz | |
mtrr: only add prefetchable resources as WRCOMB for VGA devices
Be more conservative and only add VGA devices' prefetchable
resources as write-combining in the address space. Previously
all prefetchable memory was added as a write-combining memory
type. Some hardware incorrectly advertises its BAR as
prefetchable when it shouldn't be.
A new memranges_add_resources_filter() function is added
to provide additional filtering on device and resource.
Change-Id: I3fc55b90d8c5b694c5aa9e2f34db1b4ef845ce10
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/5169
Reviewed-by: Vladimir Serbinenko <phcoder@gmail.com>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/lib')
| -rw-r--r-- | src/lib/memrange.c | 19 |
1 files changed, 15 insertions, 4 deletions
diff --git a/src/lib/memrange.c b/src/lib/memrange.c index 7fb6ef7b06..a85bc01d49 100644 --- a/src/lib/memrange.c +++ b/src/lib/memrange.c @@ -252,6 +252,7 @@ void memranges_insert(struct memranges *ranges, struct collect_context { struct memranges *ranges; unsigned long tag; + memrange_filter_t filter; }; static void collect_ranges(void *gp, struct device *dev, struct resource *res) @@ -261,12 +262,14 @@ static void collect_ranges(void *gp, struct device *dev, struct resource *res) if (res->size == 0) return; - memranges_insert(ctx->ranges, res->base, res->size, ctx->tag); + if (ctx->filter == NULL || ctx->filter(dev, res)) + memranges_insert(ctx->ranges, res->base, res->size, ctx->tag); } -void memranges_add_resources(struct memranges *ranges, - unsigned long mask, unsigned long match, - unsigned long tag) +void memranges_add_resources_filter(struct memranges *ranges, + unsigned long mask, unsigned long match, + unsigned long tag, + memrange_filter_t filter) { struct collect_context context; @@ -276,9 +279,17 @@ void memranges_add_resources(struct memranges *ranges, context.ranges = ranges; context.tag = tag; + context.filter = filter; search_global_resources(mask, match, collect_ranges, &context); } +void memranges_add_resources(struct memranges *ranges, + unsigned long mask, unsigned long match, + unsigned long tag) +{ + memranges_add_resources_filter(ranges, mask, match, tag, NULL); +} + void memranges_init(struct memranges *ranges, unsigned long mask, unsigned long match, unsigned long tag) |