summaryrefslogtreecommitdiff
path: root/src/lib
diff options
context:
space:
mode:
authorRonald G. Minnich <rminnich@google.com>2013-08-01 11:38:05 -0700
committerPatrick Georgi <patrick@georgi-clan.de>2013-12-21 22:45:06 +0100
commitc0d5eb2a332a7db1311517032e6f9ce1d5b91551 (patch)
treece25ec78b413e91d3e16fd7b12bffa408cb20f4e /src/lib
parent052bf4ba2108ecc354c08f64dc57290c9509fd22 (diff)
downloadcoreboot-c0d5eb2a332a7db1311517032e6f9ce1d5b91551.tar.xz
Pit: graphics
This includes the new dp code, which is better, and the fimd code, which is changed and improved. We took the chance to remove un-needed files, and also to remove some foolish u-boot habits, but not all of them. That will take time. With these changes we get graphics. Since the only mainboards we have with 16 bit graphics are 5:6:5, adjust edid.c to just use that format. If at some future time we need 4:4:4, which seems unlikely, we'll need to add a function to adjust the lb_framebuffer. Note that you can't just divine this from the EDID, as the graphics pipe format need not match the actual final format used. The EDID reading works. We've been requested to support hard-coded EDIDs and that will come in the next revision. Currently the hard-coded EDID is ignored for testing. Change-Id: Ib4d06dc3388ab90c834f94808a51133e5b515a4d Signed-off-by: Ronald G. Minnich <rminnich@google.com> Reviewed-on: https://gerrit.chromium.org/gerrit/64240 Reviewed-by: Stefan Reinauer <reinauer@google.com> Tested-by: Ronald G. Minnich <rminnich@chromium.org> Commit-Queue: Gabe Black <gabeblack@chromium.org> Reviewed-on: http://review.coreboot.org/4432 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
Diffstat (limited to 'src/lib')
-rw-r--r--src/lib/edid.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/lib/edid.c b/src/lib/edid.c
index b2bd9b716a..4be0dc6652 100644
--- a/src/lib/edid.c
+++ b/src/lib/edid.c
@@ -1448,12 +1448,12 @@ void set_vbe_mode_info_valid(struct edid *edid, uintptr_t fb_addr)
break;
case 16:
/* packed into 2-byte words */
- edid_fb.red_mask_pos = 12;
- edid_fb.red_mask_size = 4;
- edid_fb.green_mask_pos = 8;
- edid_fb.green_mask_size = 4;
+ edid_fb.red_mask_pos = 11;
+ edid_fb.red_mask_size = 5;
+ edid_fb.green_mask_pos = 5;
+ edid_fb.green_mask_size = 6;
edid_fb.blue_mask_pos = 0;
- edid_fb.blue_mask_size = 4;
+ edid_fb.blue_mask_size = 5;
break;
default:
printk(BIOS_SPEW, "%s: unsupported BPP %d\n", __func__,