diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-01-03 11:38:35 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-01-04 17:19:48 +0000 |
| commit | d482c7dace772278d988682e94247e3801587ff7 (patch) | |
| tree | d9f97f8ad650373791955dd2a80d271f0f17da5a /src/mainboard/advansus | |
| parent | 1db4e3a3588a8cca317e73df52e11da8d2da57ea (diff) | |
| download | coreboot-d482c7dace772278d988682e94247e3801587ff7.tar.xz | |
amdfam10 boards: Drop global bus_isa variable
Value of the global is never evaluated.
Change-Id: I74106b0f5f033053288882a5bcd3c1dba3235ac0
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/30628
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/mainboard/advansus')
| -rw-r--r-- | src/mainboard/advansus/a785e-i/get_bus_conf.c | 8 | ||||
| -rw-r--r-- | src/mainboard/advansus/a785e-i/irq_tables.c | 1 | ||||
| -rw-r--r-- | src/mainboard/advansus/a785e-i/mptable.c | 2 |
3 files changed, 1 insertions, 10 deletions
diff --git a/src/mainboard/advansus/a785e-i/get_bus_conf.c b/src/mainboard/advansus/a785e-i/get_bus_conf.c index 28de27671b..a7645a8da4 100644 --- a/src/mainboard/advansus/a785e-i/get_bus_conf.c +++ b/src/mainboard/advansus/a785e-i/get_bus_conf.c @@ -23,7 +23,6 @@ /* Global variables for MB layouts and these will be shared by irqtable mptable * and acpi_tables busnum is default. */ -int bus_isa; u8 bus_rs780[11]; u8 bus_sb800[6]; u32 apicid_sb800; @@ -88,16 +87,12 @@ void get_bus_conf(void) dev = dev_find_slot(bus_sb800[0], PCI_DEVFN(sbdn_sb800 + 0x14, 4)); if (dev) { bus_sb800[1] = pci_read_config8(dev, PCI_SECONDARY_BUS); - bus_isa = pci_read_config8(dev, PCI_SUBORDINATE_BUS); - bus_isa++; } for (i = 0; i < 4; i++) { dev = dev_find_slot(bus_sb800[0], PCI_DEVFN(sbdn_sb800 + 0x15, i)); if (dev) { bus_sb800[2 + i] = pci_read_config8(dev, PCI_SECONDARY_BUS); - bus_isa = pci_read_config8(dev, PCI_SUBORDINATE_BUS); - bus_isa++; } } @@ -107,14 +102,11 @@ void get_bus_conf(void) if (dev) { bus_rs780[i] = pci_read_config8(dev, PCI_SECONDARY_BUS); if(255 != bus_rs780[i]) { - bus_isa = pci_read_config8(dev, PCI_SUBORDINATE_BUS); - bus_isa++; } } } /* I/O APICs: APIC ID Version State Address */ - bus_isa = 10; if (IS_ENABLED(CONFIG_LOGICAL_CPUS)) apicid_base = get_apicid_base(1); else diff --git a/src/mainboard/advansus/a785e-i/irq_tables.c b/src/mainboard/advansus/a785e-i/irq_tables.c index 3a76d96684..fc5edca3e0 100644 --- a/src/mainboard/advansus/a785e-i/irq_tables.c +++ b/src/mainboard/advansus/a785e-i/irq_tables.c @@ -39,7 +39,6 @@ static void write_pirq_info(struct irq_info *pirq_info, u8 bus, u8 devfn, pirq_info->rfu = rfu; } -extern u8 bus_isa; extern u8 bus_rs780[8]; extern u8 bus_sb800[6]; extern unsigned long sbdn_sb800; diff --git a/src/mainboard/advansus/a785e-i/mptable.c b/src/mainboard/advansus/a785e-i/mptable.c index aa813f2754..3952a45d33 100644 --- a/src/mainboard/advansus/a785e-i/mptable.c +++ b/src/mainboard/advansus/a785e-i/mptable.c @@ -20,7 +20,6 @@ #include <stdint.h> #include <cpu/amd/amdfam10_sysconf.h> -extern int bus_isa; extern u8 bus_rs780[11]; extern u8 bus_sb800[6]; extern u32 apicid_sb800; @@ -40,6 +39,7 @@ u8 intr_data[] = { static void *smp_write_config_table(void *v) { struct mp_config_table *mc; + int bus_isa; u32 dword = 0; u8 byte; |