summaryrefslogtreecommitdiff
path: root/src/mainboard/amd/persimmon
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2014-10-21 14:19:04 +0300
committerKyösti Mälkki <kyosti.malkki@gmail.com>2014-12-03 08:04:53 +0100
commit27c4edace6ff3246c6b0345300931850d9e7f4bc (patch)
tree4b66f94b7bb04ab298a96bb13027c6a4dc17fcd3 /src/mainboard/amd/persimmon
parentf21c2ac0556eefad4b66a8c39734a431610d9139 (diff)
downloadcoreboot-27c4edace6ff3246c6b0345300931850d9e7f4bc.tar.xz
AGESA: Report events with AGESA_EVENTLOG()
NOTE: For fam12 and fam14 ASSERT() is defined empty so execution may fall through critical failures. Change-Id: Ifef65d749d340f1df3a43b5fcb38c4315ef944e8 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: http://review.coreboot.org/7154 Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/mainboard/amd/persimmon')
-rw-r--r--src/mainboard/amd/persimmon/agesawrapper.c36
1 files changed, 14 insertions, 22 deletions
diff --git a/src/mainboard/amd/persimmon/agesawrapper.c b/src/mainboard/amd/persimmon/agesawrapper.c
index a9eda6bdca..991e0804fa 100644
--- a/src/mainboard/amd/persimmon/agesawrapper.c
+++ b/src/mainboard/amd/persimmon/agesawrapper.c
@@ -166,7 +166,7 @@ AGESA_STATUS agesawrapper_amdinitreset (
AmdResetParams.HtConfig.Depth = 0;
status = AmdInitReset ((AMD_RESET_PARAMS *)AmdParamStruct.NewStructPtr);
- if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog();
+ AGESA_EVENTLOG(status);
AmdReleaseStruct (&AmdParamStruct);
return status;
}
@@ -193,7 +193,7 @@ AGESA_STATUS agesawrapper_amdinitearly (
OemCustomizeInitEarly (AmdEarlyParamsPtr);
status = AmdInitEarly ((AMD_EARLY_PARAMS *)AmdParamStruct.NewStructPtr);
- if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog();
+ AGESA_EVENTLOG(status);
AmdReleaseStruct (&AmdParamStruct);
return status;
@@ -217,7 +217,7 @@ AGESA_STATUS agesawrapper_amdinitpost (
AmdCreateStruct (&AmdParamStruct);
status = AmdInitPost ((AMD_POST_PARAMS *)AmdParamStruct.NewStructPtr);
- if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog();
+ AGESA_EVENTLOG(status);
AmdReleaseStruct (&AmdParamStruct);
/* Initialize heap space */
@@ -245,7 +245,7 @@ AGESA_STATUS agesawrapper_amdinitenv (
AmdParamStruct.StdHeader.ImageBasePtr = 0;
AmdCreateStruct (&AmdParamStruct);
status = AmdInitEnv ((AMD_ENV_PARAMS *)AmdParamStruct.NewStructPtr);
- if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog();
+ AGESA_EVENTLOG(status);
/* Initialize Subordinate Bus Number and Secondary Bus Number
* In platform BIOS this address is allocated by PCI enumeration code
Modify D1F0x18
@@ -370,7 +370,7 @@ AGESA_STATUS agesawrapper_amdinitmid (
AmdCreateStruct (&AmdParamStruct);
status = AmdInitMid ((AMD_MID_PARAMS *)AmdParamStruct.NewStructPtr);
- if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog();
+ AGESA_EVENTLOG(status);
AmdReleaseStruct (&AmdParamStruct);
return status;
@@ -399,10 +399,8 @@ AGESA_STATUS agesawrapper_amdinitlate (
printk (BIOS_DEBUG, "agesawrapper_amdinitlate: AmdLateParamsPtr = %X\n", (u32)AmdLateParamsPtr);
Status = AmdInitLate (AmdLateParamsPtr);
- if (Status != AGESA_SUCCESS) {
- agesawrapper_amdreadeventlog();
- ASSERT(Status == AGESA_SUCCESS);
- }
+ AGESA_EVENTLOG(Status);
+ ASSERT(Status == AGESA_SUCCESS);
DmiTable = AmdLateParamsPtr->DmiTable;
AcpiPstate = AmdLateParamsPtr->AcpiPState;
@@ -456,7 +454,7 @@ AGESA_STATUS agesawrapper_amdinitresume (
status = AmdInitResume ((AMD_RESUME_PARAMS *)AmdParamStruct.NewStructPtr);
- if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog();
+ AGESA_EVENTLOG(status);
AmdReleaseStruct (&AmdParamStruct);
return status;
@@ -492,10 +490,8 @@ AGESA_STATUS agesawrapper_amds3laterestore (
(void **) &AmdS3LateParamsPtr->S3DataBlock.VolatileStorage);
Status = AmdS3LateRestore (AmdS3LateParamsPtr);
- if (Status != AGESA_SUCCESS) {
- agesawrapper_amdreadeventlog();
- ASSERT(Status == AGESA_SUCCESS);
- }
+ AGESA_EVENTLOG(Status);
+ ASSERT(Status == AGESA_SUCCESS);
return Status;
}
@@ -525,10 +521,8 @@ AGESA_STATUS agesawrapper_amdS3Save (
AmdS3SaveParamsPtr->StdHeader = AmdInterfaceParams.StdHeader;
Status = AmdS3Save (AmdS3SaveParamsPtr);
- if (Status != AGESA_SUCCESS) {
- agesawrapper_amdreadeventlog();
- ASSERT(Status == AGESA_SUCCESS);
- }
+ AGESA_EVENTLOG(Status);
+ ASSERT(Status == AGESA_SUCCESS);
S3DataType = S3DataTypeNonVolatile;
@@ -573,10 +567,8 @@ AGESA_STATUS agesawrapper_amdlaterunaptask (
ApExeParams.RelatedDataBlock = ConfigPtr;
Status = AmdLateRunApTask (&ApExeParams);
- if (Status != AGESA_SUCCESS) {
- agesawrapper_amdreadeventlog();
- ASSERT(Status == AGESA_SUCCESS);
- }
+ AGESA_EVENTLOG(Status);
+ ASSERT(Status == AGESA_SUCCESS);
return Status;
}