mainboard/*: Remove DUMP_ACPI_TABLES from amd boards

Dumping the ACPI tables in this way has limited use, is not likely to be
used and is poorly implemented. There are much more sophisticated tools
available on Linux for debugging ACPI as such this code is outside the
scope of coreboots 'bring up the hardware only' philosophy.

A more generic implemention could be done with hexdump() in coreboot
proper following on from this cleanup.

Change-Id: Ifd3bfb76338609d18fcf7158d3c9a6d7c06c8847
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5530
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>

17 files changed, 0 insertions, 734 deletions

diff --git a/src/mainboard/amd/bimini_fam10/acpi_tables.c b/src/mainboard/amd/bimini_fam10/acpi_tables.c
index f86ea02a81..da9be9539d 100644
--- a/src/mainboard/amd/bimini_fam10/acpi_tables.c
+++ b/src/mainboard/amd/bimini_fam10/acpi_tables.c
@@ -29,24 +29,6 @@
 
 #include "mb_sysconf.h"
 
-#define DUMP_ACPI_TABLES 0
-
-#if DUMP_ACPI_TABLES == 1
-static void dump_mem(u32 start, u32 end)
-{
-
-	u32 i;
-	print_debug("dump_mem:");
-	for (i = start; i < end; i++) {
-		if ((i & 0xf) == 0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 extern const unsigned char AmlCode_ssdt[];
 
@@ -244,29 +226,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	}
 #endif
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "srat\n");
-	dump_mem(srat, ((void *)srat) + srat->header.length);
-
-	printk(BIOS_DEBUG, "slit\n");
-	dump_mem(slit, ((void *)slit) + slit->header.length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/dbm690t/acpi_tables.c b/src/mainboard/amd/dbm690t/acpi_tables.c
index 3b659b1d1e..aa4ec24fe5 100644
--- a/src/mainboard/amd/dbm690t/acpi_tables.c
+++ b/src/mainboard/amd/dbm690t/acpi_tables.c
@@ -32,8 +32,6 @@
 
 extern u16 pm_base;
 
-#define DUMP_ACPI_TABLES 0
-
 /*
 * Assume the max pstate number is 8
 * 0x21(33 bytes) is one package length of _PSS package
@@ -42,22 +40,6 @@ extern u16 pm_base;
 #define Maxpstate 8
 #define Defpkglength 0x21
 
-#if DUMP_ACPI_TABLES == 1
-static void dump_mem(u32 start, u32 end)
-{
-
-	u32 i;
-	print_debug("dump_mem:");
-	for (i = start; i < end; i++) {
-		if ((i & 0xf) == 0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 
 unsigned long acpi_fill_mcfg(unsigned long current)
@@ -174,23 +156,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	current += ssdt->length;
 	acpi_add_table(rsdp, ssdt);
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/dinar/acpi_tables.c b/src/mainboard/amd/dinar/acpi_tables.c
index b0105651ea..117e00c4aa 100644
--- a/src/mainboard/amd/dinar/acpi_tables.c
+++ b/src/mainboard/amd/dinar/acpi_tables.c
@@ -31,27 +31,8 @@
 #include "agesawrapper.h"
 #include <cpu/amd/amdfam15.h>
 
-#define DUMP_ACPI_TABLES 0
-
-#if DUMP_ACPI_TABLES == 1
-static void dump_mem(u32 start, u32 end)
-{
-
-	u32 i;
-	print_debug("dump_mem:");
-	for (i = start; i < end; i++) {
-		if ((i & 0xf) == 0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 
-
 unsigned long acpi_fill_mcfg(unsigned long current)
 {
 	/* Just a dummy */
@@ -318,32 +299,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	current += ssdt2->length;
 	acpi_add_table(rsdp,ssdt2);
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "srat\n");
-	dump_mem(srat, ((void *)srat) + srat->header.length);
-
-	printk(BIOS_DEBUG, "slit\n");
-	dump_mem(slit, ((void *)slit) + slit->header.length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-
-	printk(BIOS_DEBUG, "hest\n");
-	dump_mem(hest, ((void *)hest) + hest->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/inagua/acpi_tables.c b/src/mainboard/amd/inagua/acpi_tables.c
index 43ee9c9019..53a266662d 100644
--- a/src/mainboard/amd/inagua/acpi_tables.c
+++ b/src/mainboard/amd/inagua/acpi_tables.c
@@ -29,25 +29,6 @@
 #include <cpu/amd/mtrr.h>
 #include <cpu/amd/amdfam14.h>
 
-#define DUMP_ACPI_TABLES 0
-
-#if DUMP_ACPI_TABLES == 1
-
-static void dump_mem(u32 start, u32 end)
-{
-
-	u32 i;
-	print_debug("dump_mem:");
-	for (i = start; i < end; i++) {
-		if ((i & 0xf) == 0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 
 unsigned long acpi_fill_ssdt_generator(unsigned long current, const char *oem_table_id)
@@ -284,38 +265,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	current += ssdt2->length;
 	acpi_add_table(rsdp,ssdt2);
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "srat\n");
-	dump_mem(srat, ((void *)srat) + srat->header.length);
-
-	printk(BIOS_DEBUG, "slit\n");
-	dump_mem(slit, ((void *)slit) + slit->header.length);
-
-	printk(BIOS_DEBUG, "alib\n");
-	dump_mem(ssdt, ((void *)alib) + alib->length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "ssdt2\n");
-	dump_mem(ssdt2, ((void *)ssdt2) + ssdt2->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-
-	printk(BIOS_DEBUG, "hest\n");
-	dump_mem(hest, ((void *)hest) + hest->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/mahogany/acpi_tables.c b/src/mainboard/amd/mahogany/acpi_tables.c
index a493ccf6c3..1b00a0391b 100644
--- a/src/mainboard/amd/mahogany/acpi_tables.c
+++ b/src/mainboard/amd/mahogany/acpi_tables.c
@@ -31,8 +31,6 @@
 #include <cpu/amd/model_fxx_powernow.h>
 #include <southbridge/amd/sb700/sb700.h>
 
-#define DUMP_ACPI_TABLES 0
-
 /*
 * Assume the max pstate number is 8
 * 0x21(33 bytes) is one package length of _PSS package
@@ -41,22 +39,6 @@
 #define Maxpstate 8
 #define Defpkglength 0x21
 
-#if DUMP_ACPI_TABLES == 1
-static void dump_mem(u32 start, u32 end)
-{
-
-	u32 i;
-	print_debug("dump_mem:");
-	for (i = start; i < end; i++) {
-		if ((i & 0xf) == 0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 
 #if CONFIG_ACPI_SSDTX_NUM >= 1
@@ -226,23 +208,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	}
 #endif
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/mahogany_fam10/acpi_tables.c b/src/mainboard/amd/mahogany_fam10/acpi_tables.c
index fd235fe010..a4de705437 100644
--- a/src/mainboard/amd/mahogany_fam10/acpi_tables.c
+++ b/src/mainboard/amd/mahogany_fam10/acpi_tables.c
@@ -29,24 +29,6 @@
 #include <cpu/amd/amdfam10_sysconf.h>
 #include "mb_sysconf.h"
 
-#define DUMP_ACPI_TABLES 0
-
-#if DUMP_ACPI_TABLES == 1
-static void dump_mem(u32 start, u32 end)
-{
-
-	u32 i;
-	print_debug("dump_mem:");
-	for (i = start; i < end; i++) {
-		if ((i & 0xf) == 0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 extern const unsigned char AmlCode_ssdt[];
 
@@ -210,30 +192,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	current += ssdt->length;
 	acpi_add_table(rsdp,ssdt);
 
-
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "srat\n");
-	dump_mem(srat, ((void *)srat) + srat->header.length);
-
-	printk(BIOS_DEBUG, "slit\n");
-	dump_mem(slit, ((void *)slit) + slit->header.length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/olivehill/acpi_tables.c b/src/mainboard/amd/olivehill/acpi_tables.c
index dd592259d5..03e68abae4 100644
--- a/src/mainboard/amd/olivehill/acpi_tables.c
+++ b/src/mainboard/amd/olivehill/acpi_tables.c
@@ -31,24 +31,6 @@
 
 #include "agesawrapper.h"
 
-#define DUMP_ACPI_TABLES 0
-
-#if DUMP_ACPI_TABLES == 1
-
-static void dump_mem(u32 start, u32 end)
-{
-	u32 i;
-	print_debug("dump_mem:");
-	for (i = start; i < end; i++) {
-		if ((i & 0xf) == 0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 
 unsigned long acpi_fill_mcfg(unsigned long current)
@@ -302,32 +284,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	current += ssdt->length;
 	acpi_add_table(rsdp, ssdt);
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "srat\n");
-	dump_mem(srat, ((void *)srat) + srat->header.length);
-
-	printk(BIOS_DEBUG, "slit\n");
-	dump_mem(slit, ((void *)slit) + slit->header.length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-
-	printk(BIOS_DEBUG, "hest\n");
-	dump_mem(hest, ((void *)hest) + hest->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/parmer/acpi_tables.c b/src/mainboard/amd/parmer/acpi_tables.c
index d93fecc0f4..f03ca6f9cc 100644
--- a/src/mainboard/amd/parmer/acpi_tables.c
+++ b/src/mainboard/amd/parmer/acpi_tables.c
@@ -31,24 +31,6 @@
 
 #include "agesawrapper.h"
 
-#define DUMP_ACPI_TABLES 0
-
-#if DUMP_ACPI_TABLES == 1
-
-static void dump_mem(u32 start, u32 end)
-{
-	u32 i;
-	print_debug("dump_mem:");
-	for (i = start; i < end; i++) {
-		if ((i & 0xf) == 0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 
 unsigned long acpi_fill_mcfg(unsigned long current)
@@ -298,32 +280,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	current += ssdt->length;
 	acpi_add_table(rsdp, ssdt);
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "srat\n");
-	dump_mem(srat, ((void *)srat) + srat->header.length);
-
-	printk(BIOS_DEBUG, "slit\n");
-	dump_mem(slit, ((void *)slit) + slit->header.length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-
-	printk(BIOS_DEBUG, "hest\n");
-	dump_mem(hest, ((void *)hest) + hest->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/persimmon/acpi_tables.c b/src/mainboard/amd/persimmon/acpi_tables.c
index 43ee9c9019..53a266662d 100644
--- a/src/mainboard/amd/persimmon/acpi_tables.c
+++ b/src/mainboard/amd/persimmon/acpi_tables.c
@@ -29,25 +29,6 @@
 #include <cpu/amd/mtrr.h>
 #include <cpu/amd/amdfam14.h>
 
-#define DUMP_ACPI_TABLES 0
-
-#if DUMP_ACPI_TABLES == 1
-
-static void dump_mem(u32 start, u32 end)
-{
-
-	u32 i;
-	print_debug("dump_mem:");
-	for (i = start; i < end; i++) {
-		if ((i & 0xf) == 0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 
 unsigned long acpi_fill_ssdt_generator(unsigned long current, const char *oem_table_id)
@@ -284,38 +265,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	current += ssdt2->length;
 	acpi_add_table(rsdp,ssdt2);
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "srat\n");
-	dump_mem(srat, ((void *)srat) + srat->header.length);
-
-	printk(BIOS_DEBUG, "slit\n");
-	dump_mem(slit, ((void *)slit) + slit->header.length);
-
-	printk(BIOS_DEBUG, "alib\n");
-	dump_mem(ssdt, ((void *)alib) + alib->length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "ssdt2\n");
-	dump_mem(ssdt2, ((void *)ssdt2) + ssdt2->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-
-	printk(BIOS_DEBUG, "hest\n");
-	dump_mem(hest, ((void *)hest) + hest->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/pistachio/acpi_tables.c b/src/mainboard/amd/pistachio/acpi_tables.c
index 30274c318a..e6a3bc00cd 100644
--- a/src/mainboard/amd/pistachio/acpi_tables.c
+++ b/src/mainboard/amd/pistachio/acpi_tables.c
@@ -32,8 +32,6 @@
 
 extern u16 pm_base;
 
-#define DUMP_ACPI_TABLES 0
-
 /*
 * Assume the max pstate number is 8
 * 0x21(33 bytes) is one package length of _PSS package
@@ -42,22 +40,6 @@ extern u16 pm_base;
 #define Maxpstate 8
 #define Defpkglength 0x21
 
-#if DUMP_ACPI_TABLES == 1
-static void dump_mem(u32 start, u32 end)
-{
-
-	u32 i;
-	print_debug("dump_mem:");
-	for (i = start; i < end; i++) {
-		if ((i & 0xf) == 0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 
 unsigned long acpi_fill_mcfg(unsigned long current)
@@ -175,23 +157,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	current += ssdt->length;
 	acpi_add_table(rsdp, ssdt);
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/serengeti_cheetah/acpi_tables.c b/src/mainboard/amd/serengeti_cheetah/acpi_tables.c
index fb31750077..3d91c54a32 100644
--- a/src/mainboard/amd/serengeti_cheetah/acpi_tables.c
+++ b/src/mainboard/amd/serengeti_cheetah/acpi_tables.c
@@ -20,24 +20,6 @@
 #include "northbridge/amd/amdk8/acpi.h"
 #include "mb_sysconf.h"
 
-#define DUMP_ACPI_TABLES 0
-
-#if DUMP_ACPI_TABLES == 1
-static void dump_mem(u32 start, u32 end)
-{
-
-	u32 i;
-	print_debug("dump_mem:");
-	for(i=start;i<end;i++) {
-		if((i & 0xf)==0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (unsigned char)*((unsigned char *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 #if CONFIG_ACPI_SSDTX_NUM >= 1
 extern const unsigned char AmlCode_ssdt2[];
@@ -290,29 +272,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	}
 #endif
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "srat\n");
-	dump_mem(srat, ((void *)srat) + srat->header.length);
-
-	printk(BIOS_DEBUG, "slit\n");
-	dump_mem(slit, ((void *)slit) + slit->header.length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c b/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c
index aa3ba05282..603b06a3fc 100644
--- a/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c
+++ b/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c
@@ -29,24 +29,6 @@
 
 #include "mb_sysconf.h"
 
-#define DUMP_ACPI_TABLES 0
-
-#if DUMP_ACPI_TABLES == 1
-static void dump_mem(u32 start, u32 end)
-{
-
-	u32 i;
-	print_debug("dump_mem:");
-	for(i=start;i<end;i++) {
-		if((i & 0xf)==0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (unsigned char)*((unsigned char *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 extern const unsigned char AmlCode_ssdt[];
 
@@ -314,29 +296,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	}
 #endif
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "srat\n");
-	dump_mem(srat, ((void *)srat) + srat->header.length);
-
-	printk(BIOS_DEBUG, "slit\n");
-	dump_mem(slit, ((void *)slit) + slit->header.length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/south_station/acpi_tables.c b/src/mainboard/amd/south_station/acpi_tables.c
index 43ee9c9019..53a266662d 100644
--- a/src/mainboard/amd/south_station/acpi_tables.c
+++ b/src/mainboard/amd/south_station/acpi_tables.c
@@ -29,25 +29,6 @@
 #include <cpu/amd/mtrr.h>
 #include <cpu/amd/amdfam14.h>
 
-#define DUMP_ACPI_TABLES 0
-
-#if DUMP_ACPI_TABLES == 1
-
-static void dump_mem(u32 start, u32 end)
-{
-
-	u32 i;
-	print_debug("dump_mem:");
-	for (i = start; i < end; i++) {
-		if ((i & 0xf) == 0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 
 unsigned long acpi_fill_ssdt_generator(unsigned long current, const char *oem_table_id)
@@ -284,38 +265,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	current += ssdt2->length;
 	acpi_add_table(rsdp,ssdt2);
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "srat\n");
-	dump_mem(srat, ((void *)srat) + srat->header.length);
-
-	printk(BIOS_DEBUG, "slit\n");
-	dump_mem(slit, ((void *)slit) + slit->header.length);
-
-	printk(BIOS_DEBUG, "alib\n");
-	dump_mem(ssdt, ((void *)alib) + alib->length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "ssdt2\n");
-	dump_mem(ssdt2, ((void *)ssdt2) + ssdt2->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-
-	printk(BIOS_DEBUG, "hest\n");
-	dump_mem(hest, ((void *)hest) + hest->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/thatcher/acpi_tables.c b/src/mainboard/amd/thatcher/acpi_tables.c
index d93fecc0f4..f03ca6f9cc 100644
--- a/src/mainboard/amd/thatcher/acpi_tables.c
+++ b/src/mainboard/amd/thatcher/acpi_tables.c
@@ -31,24 +31,6 @@
 
 #include "agesawrapper.h"
 
-#define DUMP_ACPI_TABLES 0
-
-#if DUMP_ACPI_TABLES == 1
-
-static void dump_mem(u32 start, u32 end)
-{
-	u32 i;
-	print_debug("dump_mem:");
-	for (i = start; i < end; i++) {
-		if ((i & 0xf) == 0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 
 unsigned long acpi_fill_mcfg(unsigned long current)
@@ -298,32 +280,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	current += ssdt->length;
 	acpi_add_table(rsdp, ssdt);
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "srat\n");
-	dump_mem(srat, ((void *)srat) + srat->header.length);
-
-	printk(BIOS_DEBUG, "slit\n");
-	dump_mem(slit, ((void *)slit) + slit->header.length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-
-	printk(BIOS_DEBUG, "hest\n");
-	dump_mem(hest, ((void *)hest) + hest->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/tilapia_fam10/acpi_tables.c b/src/mainboard/amd/tilapia_fam10/acpi_tables.c
index b305b40508..d8d786617f 100644
--- a/src/mainboard/amd/tilapia_fam10/acpi_tables.c
+++ b/src/mainboard/amd/tilapia_fam10/acpi_tables.c
@@ -29,24 +29,6 @@
 
 #include "mb_sysconf.h"
 
-#define DUMP_ACPI_TABLES 0
-
-#if DUMP_ACPI_TABLES == 1
-static void dump_mem(u32 start, u32 end)
-{
-
-	u32 i;
-	print_debug("dump_mem:");
-	for (i = start; i < end; i++) {
-		if ((i & 0xf) == 0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 extern const unsigned char AmlCode_ssdt[];
 
@@ -244,29 +226,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	}
 #endif
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "srat\n");
-	dump_mem(srat, ((void *)srat) + srat->header.length);
-
-	printk(BIOS_DEBUG, "slit\n");
-	dump_mem(slit, ((void *)slit) + slit->header.length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }
diff --git a/src/mainboard/amd/torpedo/acpi_tables.c b/src/mainboard/amd/torpedo/acpi_tables.c
index effe12ec74..ad0bc96bbd 100644
--- a/src/mainboard/amd/torpedo/acpi_tables.c
+++ b/src/mainboard/amd/torpedo/acpi_tables.c
@@ -29,27 +29,8 @@
 #include <cpu/amd/mtrr.h>
 #include <cpu/amd/amdfam12.h>
 
-#define DUMP_ACPI_TABLES 0
 extern u32 apicid_sb900;
 
-
-#if DUMP_ACPI_TABLES == 1
-
-static void dump_mem(u32 start, u32 end)
-{
-
-  u32 i;
-  print_debug("dump_mem:");
-  for (i = start; i < end; i++) {
-    if ((i & 0xf) == 0) {
-      printk(BIOS_DEBUG, "\n%08x:", i);
-    }
-    printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-  }
-  print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 extern const unsigned char AmlCode_ssdt[];
 
@@ -258,29 +239,6 @@ unsigned long write_acpi_tables(unsigned long start)
   acpi_create_fadt(fadt, facs, dsdt);
   acpi_add_table(rsdp, fadt);
 
-#if DUMP_ACPI_TABLES == 1
-  printk(BIOS_DEBUG, "rsdp\n");
-  dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-  printk(BIOS_DEBUG, "rsdt\n");
-  dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-  printk(BIOS_DEBUG, "madt\n");
-  dump_mem(madt, ((void *)madt) + madt->header.length);
-
-  printk(BIOS_DEBUG, "srat\n");
-  dump_mem(srat, ((void *)srat) + srat->header.length);
-
-  printk(BIOS_DEBUG, "slit\n");
-  dump_mem(slit, ((void *)slit) + slit->header.length);
-
-  printk(BIOS_DEBUG, "ssdt\n");
-  dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-  printk(BIOS_DEBUG, "fadt\n");
-  dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-#endif
-
   printk(BIOS_INFO, "ACPI: done.\n");
   return current;
 }
diff --git a/src/mainboard/amd/union_station/acpi_tables.c b/src/mainboard/amd/union_station/acpi_tables.c
index 43ee9c9019..53a266662d 100644
--- a/src/mainboard/amd/union_station/acpi_tables.c
+++ b/src/mainboard/amd/union_station/acpi_tables.c
@@ -29,25 +29,6 @@
 #include <cpu/amd/mtrr.h>
 #include <cpu/amd/amdfam14.h>
 
-#define DUMP_ACPI_TABLES 0
-
-#if DUMP_ACPI_TABLES == 1
-
-static void dump_mem(u32 start, u32 end)
-{
-
-	u32 i;
-	print_debug("dump_mem:");
-	for (i = start; i < end; i++) {
-		if ((i & 0xf) == 0) {
-			printk(BIOS_DEBUG, "\n%08x:", i);
-		}
-		printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));
-	}
-	print_debug("\n");
-}
-#endif
-
 extern const unsigned char AmlCode[];
 
 unsigned long acpi_fill_ssdt_generator(unsigned long current, const char *oem_table_id)
@@ -284,38 +265,6 @@ unsigned long write_acpi_tables(unsigned long start)
 	current += ssdt2->length;
 	acpi_add_table(rsdp,ssdt2);
 
-#if DUMP_ACPI_TABLES == 1
-	printk(BIOS_DEBUG, "rsdp\n");
-	dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t));
-
-	printk(BIOS_DEBUG, "rsdt\n");
-	dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t));
-
-	printk(BIOS_DEBUG, "madt\n");
-	dump_mem(madt, ((void *)madt) + madt->header.length);
-
-	printk(BIOS_DEBUG, "srat\n");
-	dump_mem(srat, ((void *)srat) + srat->header.length);
-
-	printk(BIOS_DEBUG, "slit\n");
-	dump_mem(slit, ((void *)slit) + slit->header.length);
-
-	printk(BIOS_DEBUG, "alib\n");
-	dump_mem(ssdt, ((void *)alib) + alib->length);
-
-	printk(BIOS_DEBUG, "ssdt\n");
-	dump_mem(ssdt, ((void *)ssdt) + ssdt->length);
-
-	printk(BIOS_DEBUG, "ssdt2\n");
-	dump_mem(ssdt2, ((void *)ssdt2) + ssdt2->length);
-
-	printk(BIOS_DEBUG, "fadt\n");
-	dump_mem(fadt, ((void *)fadt) + fadt->header.length);
-
-	printk(BIOS_DEBUG, "hest\n");
-	dump_mem(hest, ((void *)hest) + hest->header.length);
-#endif
-
 	printk(BIOS_INFO, "ACPI: done.\n");
 	return current;
 }