diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-01-01 08:58:59 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-01-04 04:50:40 +0000 |
| commit | c859f10eec6b8f8120c4683f281461a68f9b374f (patch) | |
| tree | 700e5166d0720470eba76f46259850957b2e99a1 /src/mainboard/aopen/dxplplusu | |
| parent | 768cd37bc3aa399488bf299486b46e1b1d4f1da7 (diff) | |
| download | coreboot-c859f10eec6b8f8120c4683f281461a68f9b374f.tar.xz | |
intel/e7505: Drop ECC scrubber code
This was already disabled and mostly incompatible
with romstage having stack in CAR.
Change-Id: I1fe02bef668a5bc8ce3d5a1d8090670752b10c3e
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/30621
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/mainboard/aopen/dxplplusu')
| -rw-r--r-- | src/mainboard/aopen/dxplplusu/Kconfig | 1 | ||||
| -rw-r--r-- | src/mainboard/aopen/dxplplusu/romstage.c | 12 |
2 files changed, 0 insertions, 13 deletions
diff --git a/src/mainboard/aopen/dxplplusu/Kconfig b/src/mainboard/aopen/dxplplusu/Kconfig index 8e3178529e..85c45d51f3 100644 --- a/src/mainboard/aopen/dxplplusu/Kconfig +++ b/src/mainboard/aopen/dxplplusu/Kconfig @@ -12,7 +12,6 @@ config BOARD_SPECIFIC_OPTIONS select UDELAY_TSC select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_2048 -# select HW_SCRUBBER config MAINBOARD_DIR string diff --git a/src/mainboard/aopen/dxplplusu/romstage.c b/src/mainboard/aopen/dxplplusu/romstage.c index 73a9ce07e3..75aad28093 100644 --- a/src/mainboard/aopen/dxplplusu/romstage.c +++ b/src/mainboard/aopen/dxplplusu/romstage.c @@ -66,18 +66,6 @@ void mainboard_romstage_entry(unsigned long bist) /* The real MCH initialisation. */ e7505_mch_init(memctrl); - /* - * ECC scrub invalidates cache, so all stack in CAR - * is lost. Only return addresses from main() and - * scrub_ecc() are recovered to stack via xmm0-xmm3. - */ -#if IS_ENABLED(CONFIG_HW_SCRUBBER) -#if !IS_ENABLED(CONFIG_USBDEBUG_IN_ROMSTAGE) - unsigned long ret_addr = (unsigned long)((unsigned long*)&bist - 1); - e7505_mch_scrub_ecc(ret_addr); -#endif -#endif - /* Hook for post ECC scrub settings and debug. */ e7505_mch_done(memctrl); |