diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2020-05-21 00:28:08 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2020-05-26 11:36:07 +0000 |
| commit | c072e794e62433d75369b50c7e9c90c50e47ba89 (patch) | |
| tree | 6b6883ee8c034a0508277019337f5b0de06f0142 /src/mainboard/asrock | |
| parent | f689d2ee19b25154b0f84fdff1cc2aaa337c4bab (diff) | |
| download | coreboot-c072e794e62433d75369b50c7e9c90c50e47ba89.tar.xz | |
AGESA f14/f15tn/f16kb: Factor out AGESA_VERSION_STRING
We use the same AGESA version numbers on all but one mainboard, so we
might as well factor them out. The only exception is asrock/e350m1,
which has the f15tn/f16kb version number even though it actually uses
AGESA f14. To preserve reproducibility, do not change it in this commit.
TEST=Use abuild --timeless to check that all AGESA f14/f15tn/f16kb
mainboards result in identical coreboot binaries.
Change-Id: I0dad2352ccda454d5545f17228d52e4ff4f23f20
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41591
Reviewed-by: Mike Banon <mikebdp2@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/asrock')
| -rw-r--r-- | src/mainboard/asrock/e350m1/buildOpts.c | 2 | ||||
| -rw-r--r-- | src/mainboard/asrock/imb-a180/buildOpts.c | 4 |
2 files changed, 2 insertions, 4 deletions
diff --git a/src/mainboard/asrock/e350m1/buildOpts.c b/src/mainboard/asrock/e350m1/buildOpts.c index fd3ddc86ca..b674a5a6b4 100644 --- a/src/mainboard/asrock/e350m1/buildOpts.c +++ b/src/mainboard/asrock/e350m1/buildOpts.c @@ -216,6 +216,8 @@ CONST AP_MTRR_SETTINGS ROMDATA OntarioApMtrrSettingsList[] = #include "cpuLateInit.h" #include "GnbInterface.h" +/* FIXME: This is most likely wrong */ +#undef AGESA_VERSION_STRING // This is the release version number of the AGESA component // This string MUST be exactly 12 characters long #define AGESA_VERSION_STRING {'V', '0', '.', '0', '.', '0', '.', '1', ' ', ' ', ' ', ' '} diff --git a/src/mainboard/asrock/imb-a180/buildOpts.c b/src/mainboard/asrock/imb-a180/buildOpts.c index 88db840359..97d49c765d 100644 --- a/src/mainboard/asrock/imb-a180/buildOpts.c +++ b/src/mainboard/asrock/imb-a180/buildOpts.c @@ -225,10 +225,6 @@ CONST AP_MTRR_SETTINGS ROMDATA KabiniApMtrrSettingsList[] = #include "cpuLateInit.h" #include "GnbInterface.h" - // This is the release version number of the AGESA component - // This string MUST be exactly 12 characters long -#define AGESA_VERSION_STRING {'V', '0', '.', '0', '.', '0', '.', '1', ' ', ' ', ' ', ' '} - /* MEMORY_BUS_SPEED */ //#define DDR400_FREQUENCY 200 ///< DDR 400 //#define DDR533_FREQUENCY 266 ///< DDR 533 |