diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2010-11-21 11:36:03 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2010-11-21 11:36:03 +0000 |
| commit | 6dc92f0d1a4b6a79c2db800c5bd071daa75a9a23 (patch) | |
| tree | 1b06518d371222763417675b38161d261bd42f93 /src/mainboard/dell/s1850 | |
| parent | 86a571797d9ede9d79edcfdce38f50a80b9a49f9 (diff) | |
| download | coreboot-6dc92f0d1a4b6a79c2db800c5bd071daa75a9a23.tar.xz | |
Use DIMM0 et al in lots more places instead of hardocding values.
The (0xa << 3) expression equals 0x50, i.e. DIMM0.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6103 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/mainboard/dell/s1850')
| -rw-r--r-- | src/mainboard/dell/s1850/romstage.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/src/mainboard/dell/s1850/romstage.c b/src/mainboard/dell/s1850/romstage.c index a935ffc13d..0b64c9d9eb 100644 --- a/src/mainboard/dell/s1850/romstage.c +++ b/src/mainboard/dell/s1850/romstage.c @@ -19,6 +19,7 @@ #include "s1850_fixups.c" #include "northbridge/intel/e7520/memory_initialized.c" #include "cpu/x86/bist.h" +#include <spd.h> #define CONSOLE_SERIAL_DEV PNP_DEV(0x2e, PC8374_SP1) @@ -149,10 +150,7 @@ static void main(unsigned long bist) u16 w; u32 l; int do_reset; - /* - * - * - */ + static const struct mem_controller mch[] = { { .node_id = 0, @@ -164,8 +162,8 @@ static void main(unsigned long bist) */ /* the wiring on this part is really messed up */ /* this is my best guess so far */ - .channel0 = {(0xa<<3)|0, (0xa<<3)|1, (0xa<<3)|2, (0xa<<3)|3, }, - .channel1 = {(0xa<<3)|4, (0xa<<3)|5, (0xa<<3)|6, (0xa<<3)|7, }, + .channel0 = {DIMM0, DIMM1, DIMM2, DIMM3, }, + .channel1 = {DIMM4, DIMM5, DIMM6, DIMM7, }, } }; |