diff options
author | Paul Menzel <paulepanter@users.sourceforge.net> | 2013-02-23 21:31:23 +0100 |
---|---|---|
committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2013-02-25 18:47:00 +0100 |
commit | 528640d141193b4aaeb6b8956d4fbc7381df9eb3 (patch) | |
tree | 98e9dfa7e912b8187600d1347f369a02598d56a3 /src/mainboard/digitallogic | |
parent | 1fc7416545bde75d9cc401638f28ebfb751b663e (diff) | |
download | coreboot-528640d141193b4aaeb6b8956d4fbc7381df9eb3.tar.xz |
mainboard.c: Name enable_dev function uniformly `mainboard_enable`
To reduce the differences between these file name the enabling
device function in the directory `src/mainboard` uniformly
`mainboard_enable` [1].
Thanks to the awesome help of gnomon and BlastHardcheese in the
IRC channel #sed on <irc.freenode.net>. gnomon came up with the
following command to do the actual work.
$ cd src/mainboard
$ for f in */*/mainboard.c ; \
> do src="$(awk '/\.enable_dev = /{v=$NF; sub(/,$/,"",v); print v}' "$f")" ; \
> [[ -z $src ]] && continue ; \
> printf '%s\n' "g/${src}/s/${src}\([,(]\)/mainboard_enable\1/p" w | ed -s "$f" ; \
> done
`src/mainboard/digitallogic/msm586seg/mainboard.c` and
`src/mainboard/technologic/ts5300/mainboard.c` had to be adapted
manually as no comma was used separating the struct members.
And with the following statement, gnomon is even more likable!
My pleasure entirely. Good luck with coreboot; I'm a big fan of the project.
[1] http://www.coreboot.org/pipermail/coreboot/2013-February/074548.html
Change-Id: Ife9cd0c2d9cc1ed14afc6d40063450553f06a6c6
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/2493
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/mainboard/digitallogic')
-rw-r--r-- | src/mainboard/digitallogic/msm586seg/mainboard.c | 4 | ||||
-rw-r--r-- | src/mainboard/digitallogic/msm800sev/mainboard.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/mainboard/digitallogic/msm586seg/mainboard.c b/src/mainboard/digitallogic/msm586seg/mainboard.c index f2902c80fb..6cb5f07cc9 100644 --- a/src/mainboard/digitallogic/msm586seg/mainboard.c +++ b/src/mainboard/digitallogic/msm586seg/mainboard.c @@ -31,7 +31,7 @@ static void irqdump(void) /* TODO: finish up mmcr struct in sc520.h, and; - set ADDDECTL (now done in raminit.c in cpu/amd/sc520 */ -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { //volatile struct mmcrpic *pic = MMCRPIC; volatile struct mmcr *mmcr = MMCRDEFAULT; @@ -129,6 +129,6 @@ static void enable_dev(struct device *dev) } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/digitallogic/msm800sev/mainboard.c b/src/mainboard/digitallogic/msm800sev/mainboard.c index 2b2b9fe976..b8e3ba1eae 100644 --- a/src/mainboard/digitallogic/msm800sev/mainboard.c +++ b/src/mainboard/digitallogic/msm800sev/mainboard.c @@ -26,12 +26,12 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "MSM800SEV EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; |