diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2019-11-12 16:42:33 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-11-18 11:46:26 +0000 |
| commit | 9c538348d8ccaef2c3dd6b898a1f44b00ea59690 (patch) | |
| tree | 79eac3af79546b14b110b059e31eb18d33de4ce0 /src/mainboard/gigabyte | |
| parent | 934b8da442a04978c6320299c616d3e8f05cb731 (diff) | |
| download | coreboot-9c538348d8ccaef2c3dd6b898a1f44b00ea59690.tar.xz | |
nb/intel/sandybridge: Make the mainboard_rcba_config hook optional
This also changes the name to mainboard_late_rcba_config to better
reflect what it does.
This adds an empty weakly linked default. The rationale behind this
change is that without an implementation of the hook some features
might not work but that the result is likely still able to boot, so it
can be made optional.
Change-Id: I1897d0f5ca7427d304a425f5256cd43c088ff936
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36781
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/mainboard/gigabyte')
| -rw-r--r-- | src/mainboard/gigabyte/ga-b75m-d3h/romstage.c | 2 | ||||
| -rw-r--r-- | src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c | 4 |
2 files changed, 1 insertions, 5 deletions
diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c b/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c index f67d51b8be..25e1d0385e 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c +++ b/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c @@ -87,7 +87,7 @@ void mainboard_get_spd(spd_raw_data *spd, bool id_only) read_spd(&spd[3], 0x53, id_only); } -void mainboard_rcba_config(void) +void mainboard_late_rcba_config(void) { /* Enable HECI */ RCBA32(FD2) &= ~0x2; diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c b/src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c index 1df5bfd80c..57cc0706d9 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c @@ -27,10 +27,6 @@ void pch_enable_lpc(void) { } -void mainboard_rcba_config(void) -{ -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 0, 0 }, { 1, 0, 0 }, |